Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1937233002: aw: Fix activityWrapsContext condition (Closed)

Created:
4 years, 7 months ago by boliu
Modified:
4 years, 7 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Fix activityWrapsContext condition Totally did the opposite thing for r390716. Fix it! BUG=608397 Committed: https://crrev.com/1fc9c657810e48b9f4677cf4d5dd46027894a64c Cr-Commit-Position: refs/heads/master@{#391015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
boliu
ptal
4 years, 7 months ago (2016-05-02 17:59:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937233002/1
4 years, 7 months ago (2016-05-02 18:00:18 UTC) #4
sgurun-gerrit only
lgtm
4 years, 7 months ago (2016-05-02 18:08:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937233002/1
4 years, 7 months ago (2016-05-02 18:09:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 18:58:22 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 18:59:26 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1fc9c657810e48b9f4677cf4d5dd46027894a64c
Cr-Commit-Position: refs/heads/master@{#391015}

Powered by Google App Engine
This is Rietveld 408576698