Issue 1937223002: All initializer expressions are serialized, even if not all of them are constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1937223002: All initializer expressions are serialized, even if not all of them are constants. (Closed)

Created:
4 years, 7 months ago by scheglov

Modified:
4 years, 7 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

All initializer expressions are serialized, even if not all of them are constants. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f56a3c9765e3a8fa4961bef394d9324b3ab617dd

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -40 lines)			Patch
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	2 chunks	+6 lines, -9 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_ast_test.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	9 chunks	+10 lines, -25 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 7 months ago (2016-05-02 17:42:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f56a3c9765e3a8fa4961bef394d9324b3ab617dd (presubmit successful).