chrome/browser/spellchecker/spellcheck_service_unittest.cc - Issue 1937203002: Fixed hasty language selection in GetCorrespondingSpellCheckLanguage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service_unittest.cc

Issue 1937203002: Fixed hasty language selection in GetCorrespondingSpellCheckLanguage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added another unit test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/spellchecker/spellcheck_service_unittest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_service_unittest.cc b/chrome/browser/spellchecker/spellcheck_service_unittest.cc

index bdd0a76c6ba30e1ee817c9f66e311e1ff7be5137..1dfaada37c12395ab9652cd27929200b5f8059cf 100644

--- a/chrome/browser/spellchecker/spellcheck_service_unittest.cc

+++ b/chrome/browser/spellchecker/spellcheck_service_unittest.cc

@@ -112,8 +112,10 @@ INSTANTIATE_TEST_CASE_P(

TestCases,

SpellcheckServiceUnitTest,

testing::Values(

+ TestCase("en,aa", "aa", "", ""),

TestCase("en,en-JP,fr,aa", "fr", "fr", "fr"),

TestCase("en,en-JP,fr,zz,en-US", "fr", "fr,en-US", "fr"),

+ TestCase("en,en-US,en-GB", "en-GB", "en-US,en-GB", "en-GB"),

TestCase("en,en-US,en-AU", "en-AU", "en-US,en-AU", "en-AU"),

TestCase("en,en-US,en-AU", "en-US", "en-US,en-AU", "en-US"),

TestCase("en,en-US", "en-US", "en-US", "en-US"),

« no previous file with comments | « no previous file | chrome/common/spellcheck_common.cc » ('j') | chrome/common/spellcheck_common.cc » ('J')