Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1937143002: Revert of Update libjpeg-turbo to 1.4.90 (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@halffloat
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update libjpeg-turbo to 1.4.90 (patchset #1 id:20001 of https://codereview.chromium.org/1940903002/ ) Reason for revert: Clang wants "strbeq" and gcc wants "streqb". Uggh. https://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-Android/builds/1766/steps/compile_skia%20on%20Mac/logs/stdio Original issue's description: > Update libjpeg-turbo to 1.4.90 > > Google3, Chrome, and Android are considering updates. Let's start > testing Skia on the newest version. > https://critique.corp.google.com/#review/116667446 > https://codereview.chromium.org/1934113002 > https://buganizer.corp.google.com/u/0/issues/28268702 > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1940903002 > > Committed: https://skia.googlesource.com/skia/+/3994c161ec5a2b83e8f6bab4d9c469eec2668d92 TBR=scroggo@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a13efa690622d753303970ed8bddf1d8b84da0dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/libjpeg-turbo.gyp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Update libjpeg-turbo to 1.4.90
4 years, 7 months ago (2016-05-02 16:14:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937143002/1
4 years, 7 months ago (2016-05-02 16:14:18 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 16:14:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a13efa690622d753303970ed8bddf1d8b84da0dc

Powered by Google App Engine
This is Rietveld 408576698