Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1937093002:
Fix Windows component builds: Use component type in gyp build for media_gpu (Closed)
|
Created:
4 years, 7 months ago by Mark Dittmer Modified:
4 years, 7 months ago Reviewers:
Nico CC:
chromium-reviews, feature-media-reviews_chromium.org, dvadym, Fady Samuel Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix Windows component builds: Use component type in gyp build for media_gpu
R=thakis@chromium.org
BUG=608348
TBR=xhwang@chromium.org,piman@chromium.org
Committed: https://crrev.com/5b44a658cef8d9ae2319cbdfe1d7f534e453cab1
Cr-Commit-Position: refs/heads/master@{#391014}
Patch Set 1 #Patch Set 2 : Add media_gpu dep to content_common to fix mac gyp build #Patch Set 3 : Add dep on gfx_x11 in cros/x11 case for media_gpu gyp build #Patch Set 4 : Add x11 lib build config to cros/x11 gyp build of media/gpu #Patch Set 5 : Export InitializeVideoToolbox #
Messages
Total messages: 40 (21 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937093002/1
lgtm Makes sense, and I checked that this fixes the problem.
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937093002/1
(filed https://bugs.chromium.org/p/chromium/issues/detail?id=608359 for the red boxes; those look unrelated)
Description was changed from ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org BUG=608348 ========== to ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org TBR=xhwang@chromium.org BUG=608348 ==========
Description was changed from ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org TBR=xhwang@chromium.org BUG=608348 ========== to ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org BUG=608348 TBR=xhwang@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Add media_gpu dep to content_common to fix mac gyp build
Description was changed from ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org BUG=608348 TBR=xhwang@chromium.org ========== to ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org BUG=608348 TBR=xhwang@chromium.org,piman@chromium.org ==========
The CQ bit was checked by markdittmer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1937093002/#ps20001 (title: "Add media_gpu dep to content_common to fix mac gyp build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937093002/20001
The CQ bit was unchecked by markdittmer@chromium.org
The CQ bit was checked by markdittmer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937093002/20001
Add dep on gfx_x11 in cros/x11 case for media_gpu gyp build
The CQ bit was checked by markdittmer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1937093002/#ps40001 (title: "Add dep on gfx_x11 in cros/x11 case for media_gpu gyp build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937093002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
Add x11 lib build config to cros/x11 gyp build of media/gpu
The CQ bit was checked by markdittmer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1937093002/#ps60001 (title: "Add x11 lib build config to cros/x11 gyp build of media/gpu")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937093002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937093002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
Export InitializeVideoToolbox
The CQ bit was checked by markdittmer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1937093002/#ps80001 (title: "Export InitializeVideoToolbox")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937093002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937093002/80001
Message was sent while issue was closed.
Description was changed from ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org BUG=608348 TBR=xhwang@chromium.org,piman@chromium.org ========== to ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org BUG=608348 TBR=xhwang@chromium.org,piman@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org BUG=608348 TBR=xhwang@chromium.org,piman@chromium.org ========== to ========== Fix Windows component builds: Use component type in gyp build for media_gpu R=thakis@chromium.org BUG=608348 TBR=xhwang@chromium.org,piman@chromium.org Committed: https://crrev.com/5b44a658cef8d9ae2319cbdfe1d7f534e453cab1 Cr-Commit-Position: refs/heads/master@{#391014} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/5b44a658cef8d9ae2319cbdfe1d7f534e453cab1 Cr-Commit-Position: refs/heads/master@{#391014} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
