Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h

Issue 1937033002: Fix crash in CSSStyleSheetResource::appendData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove client in destructor Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h
diff --git a/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h b/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h
index 9117b08c3df9761800f35a2520566af23a98033d..af3a8f302e9d2e5d630ff896bf0cd1d1b0c7642c 100644
--- a/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h
+++ b/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h
@@ -88,11 +88,13 @@ private:
class CSSPreloaderResourceClient : public StyleSheetResourceClient {
public:
CSSPreloaderResourceClient(Resource*, HTMLResourcePreloader*);
+ ~CSSPreloaderResourceClient();
void notifyFinished(Resource*) override;
void didAppendFirstData(const CSSStyleSheetResource*) override;
String debugName() const override { return "CSSPreloaderResourceClient"; }
private:
+ void stopObserving();
Persistent<Resource> m_resource;
WeakPersistent<HTMLResourcePreloader> m_preloader;
};

Powered by Google App Engine
This is Rietveld 408576698