Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1937003002: Track NTP snippets data usage. (Closed)

Created:
4 years, 7 months ago by sfiera
Modified:
4 years, 7 months ago
Reviewers:
Marc Treib, bengr
CC:
chromium-reviews, blundell+watchlist_chromium.org, mcwilliams+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tracker-enum
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track NTP snippets data usage. Adds new dependency edge components/{ntp_snippets => data_use_measurement/core}. BUG=601380 Committed: https://crrev.com/4bbaba9313c70ca1b5f332ce4458192335d2f14d Cr-Commit-Position: refs/heads/master@{#391468}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/ntp_snippets.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
sfiera
4 years, 7 months ago (2016-05-02 11:18:50 UTC) #3
Marc Treib
LGTM with one comment https://codereview.chromium.org/1937003002/diff/1/components/ntp_snippets/BUILD.gn File components/ntp_snippets/BUILD.gn (right): https://codereview.chromium.org/1937003002/diff/1/components/ntp_snippets/BUILD.gn#newcode24 components/ntp_snippets/BUILD.gn:24: "//components/data_use_measurement/core", This can go into ...
4 years, 7 months ago (2016-05-02 11:21:38 UTC) #4
sfiera
https://codereview.chromium.org/1937003002/diff/1/components/ntp_snippets/BUILD.gn File components/ntp_snippets/BUILD.gn (right): https://codereview.chromium.org/1937003002/diff/1/components/ntp_snippets/BUILD.gn#newcode24 components/ntp_snippets/BUILD.gn:24: "//components/data_use_measurement/core", On 2016/05/02 11:21:38, Marc Treib wrote: > This ...
4 years, 7 months ago (2016-05-02 11:55:46 UTC) #5
bengr
lgtm
4 years, 7 months ago (2016-05-03 20:15:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937003002/20001
4 years, 7 months ago (2016-05-04 08:17:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/514) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-04 08:19:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937003002/20001
4 years, 7 months ago (2016-05-04 08:41:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/509) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-04 08:43:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1937003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1937003002/40001
4 years, 7 months ago (2016-05-04 08:44:32 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 09:51:56 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 09:52:58 UTC) #22
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4bbaba9313c70ca1b5f332ce4458192335d2f14d
Cr-Commit-Position: refs/heads/master@{#391468}

Powered by Google App Engine
This is Rietveld 408576698