Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 19370003: Enable allocation sinking for closures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
===================================================================
--- runtime/vm/flow_graph_type_propagator.cc (revision 25661)
+++ runtime/vm/flow_graph_type_propagator.cc (working copy)
@@ -865,8 +865,8 @@
}
-CompileType DropTempsInstr::ComputeType() const {
- return CompileType::Dynamic();
+CompileType* DropTempsInstr::ComputeInitialType() const {
+ return value()->Type();
}
@@ -915,8 +915,14 @@
CompileType AllocateObjectInstr::ComputeType() const {
+ if (!closure_function().IsNull()) {
+ ASSERT(cls().raw() == closure_function().signature_class());
+ return CompileType(CompileType::kNonNullable,
+ cls().id(),
+ &Type::ZoneHandle(cls().SignatureType()));
+ }
// TODO(vegorov): Incorporate type arguments into the returned type.
- return CompileType::FromCid(cid_);
+ return CompileType::FromCid(cls().id());
}
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698