Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1936993002: LayoutTests: adapt framework blackboxing test to V8's interpreter. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: adapt framework blackboxing test to V8's interpreter. When debugging using V8's interpreter, there are slight differences at return statements that directly returns the value of the previous statement. This fixes the test case to work regardless of the difference. R=machenbach@chromium.org, rmcilroy@chromium.org BUG=chromium:595646 Committed: https://crrev.com/fbb9c98e14eedc0e1177c5919ea078a5ef1e0898 Cr-Commit-Position: refs/heads/master@{#390929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 7 months ago (2016-05-02 09:49:02 UTC) #1
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-02 12:19:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936993002/1
4 years, 7 months ago (2016-05-02 12:20:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 13:23:20 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 13:25:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbb9c98e14eedc0e1177c5919ea078a5ef1e0898
Cr-Commit-Position: refs/heads/master@{#390929}

Powered by Google App Engine
This is Rietveld 408576698