S390: Fix storing to below stack to avoid sampler handler corrupting stored value

src/s390/assembler-s390.cc

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
 // are met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 346 matching lines @@
   Opcode opcode = Instruction::S390OpcodeValue(buffer_ + pos);
 
   if (is_branch != nullptr) {
     *is_branch = (opcode == BRC || opcode == BRCT || opcode == BRCTG ||
                   opcode == BRCL || opcode == BRASL);
   }
 
   if (BRC == opcode || BRCT == opcode || BRCTG == opcode) {
     int16_t imm16 = target_pos - pos;
     instr &= (~0xffff);
-    CHECK(is_int16(imm16));
+    DCHECK(is_int16(imm16));
     instr_at_put<FourByteInstr>(pos, instr | (imm16 >> 1));
     return;
   } else if (BRCL == opcode || LARL == opcode || BRASL == opcode) {
     // Immediate is in # of halfwords
     int32_t imm32 = target_pos - pos;
     instr &= (~static_cast<uint64_t>(0xffffffff));
     instr_at_put<SixByteInstr>(pos, instr | (imm32 >> 1));
     return;
   } else if (LLILF == opcode) {
-    CHECK(target_pos == kEndOfChain || target_pos >= 0);
+    DCHECK(target_pos == kEndOfChain || target_pos >= 0);
     // Emitted label constant, not part of a branch.
     // Make label relative to Code* of generated Code object.
     int32_t imm32 = target_pos + (Code::kHeaderSize - kHeapObjectTag);
     instr &= (~static_cast<uint64_t>(0xffffffff));
     instr_at_put<SixByteInstr>(pos, instr | imm32);
     return;
   }
   DCHECK(false);
 }
 
@@ skipping 2143 matching lines @@
   sil_form(MVHI, opnd1.getBaseRegister(), opnd1.getDisplacement(), i2);
 }
 
 // Move integer (64)
 void Assembler::mvghi(const MemOperand& opnd1, const Operand& i2) {
   sil_form(MVGHI, opnd1.getBaseRegister(), opnd1.getDisplacement(), i2);
 }
 
 // Store Register (64)
 void Assembler::stg(Register src, const MemOperand& dst) {
+  DCHECK(!(dst.rb().code() == 15 && dst.offset() < 0));
   rxy_form(STG, src, dst.rx(), dst.rb(), dst.offset());
 }
 
 // Insert Character
 void Assembler::ic_z(Register r1, const MemOperand& opnd) {
   rx_form(IC_z, r1, opnd.rx(), opnd.rb(), opnd.offset());
 }
 
 // Insert Character
 void Assembler::icy(Register r1, const MemOperand& opnd) {
@@ skipping 177 matching lines @@
            Register::from_code(r2.code()));
 }
 
 // Store Double (64)
 void Assembler::std(DoubleRegister r1, const MemOperand& opnd) {
   rx_form(STD, r1, opnd.rx(), opnd.rb(), opnd.offset());
 }
 
 // Store Double (64)
 void Assembler::stdy(DoubleRegister r1, const MemOperand& opnd) {
+  DCHECK(!(opnd.rb().code() == 15 && opnd.offset() < 0));
   rxy_form(STDY, r1, opnd.rx(), opnd.rb(), opnd.offset());
 }
 
 // Store Float (32)
 void Assembler::ste(DoubleRegister r1, const MemOperand& opnd) {
   rx_form(STE, r1, opnd.rx(), opnd.rb(), opnd.offset());
 }
 
 // Store Float (32)
 void Assembler::stey(DoubleRegister r1, const MemOperand& opnd) {
+  DCHECK(!(opnd.rb().code() == 15 && opnd.offset() < 0));
   rxy_form(STEY, r1, opnd.rx(), opnd.rb(), opnd.offset());
 }
 
 // Load Double (64)
 void Assembler::ld(DoubleRegister r1, const MemOperand& opnd) {
   DCHECK(is_uint12(opnd.offset()));
   rx_form(LD, r1, opnd.rx(), opnd.rb(), opnd.offset() & 0xfff);
 }
 
 // Load Double (64)
@@ skipping 291 matching lines @@
 
     reloc_info_writer.Write(&rinfo);
   }
 
   reloc_info_writer.Finish();
 }
 
 }  // namespace internal
 }  // namespace v8
 #endif  // V8_TARGET_ARCH_S390