chrome/browser/ui/app_list/search/webstore/webstore_provider.cc - Issue 1936953002: Don't return installed apps in webstore searches in Launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

Issue 1936953002: Don't return installed apps in webstore searches in Launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address final reviews Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate.h ('k') | chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

diff --git a/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc b/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

index c7854aba07d60630b06b3834cf4257679cb036da..044cfaca7751e398a314e3a6fc1f7037fa4c5801 100644

--- a/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

+++ b/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

@@ -15,6 +15,7 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search/search.h"

+#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"

#include "chrome/browser/ui/app_list/search/common/json_response_fetcher.h"

#include "chrome/browser/ui/app_list/search/search_webstore_result.h"

#include "chrome/browser/ui/app_list/search/webstore/webstore_result.h"

@@ -170,6 +171,10 @@ std::unique_ptr<SearchResult> WebstoreProvider::CreateResult(

return std::unique_ptr<SearchResult>();

}

+ // If an app is already installed, don't show it in results.

+ if (controller_->IsExtensionInstalled(profile_, app_id))

+ return std::unique_ptr<SearchResult>();

GURL icon_url(icon_url_string);

if (!icon_url.is_valid())

return std::unique_ptr<SearchResult>();