third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1936913002: [CSS] Accept 8 (#RRGGBBAA) and 4 (#RGBA) value hex colors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1936913002: [CSS] Accept 8 (#RRGGBBAA) and 4 (#RGBA) value hex colors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add quirks mode fastParseColorInternal() test cases. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/dom/rgb-color-parser-expected.txt ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

index f963e93fd3eb57920355d5c20eceefdf9fe0bc3b..33a29e13cf63751eac303eef181606efce2df827 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -387,7 +387,7 @@ static bool fastParseColorInternal(RGBA32& rgb, const CharacterType* characters,

if (length >= 4 && characters[0] == '#')

return Color::parseHexColor(characters + 1, length - 1, rgb);

- if (quirksMode && length >= 3) {

+ if (quirksMode && (length == 3 || length == 6)) {

if (Color::parseHexColor(characters, length, rgb))

return true;

}