Allow SAML logins to use the webcam

chrome/browser/chromeos/settings/device_settings_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_provider.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 52 matching lines @@
     kDeviceAttestationEnabled,
     kDeviceDisabled,
     kDeviceDisabledMessage,
     kDeviceOwner,
     kDeviceQuirksDownloadEnabled,
     kDisplayRotationDefault,
     kExtensionCacheSize,
     kHeartbeatEnabled,
     kHeartbeatFrequency,
     kLoginAuthenticationBehavior,
+    kLoginVideoCaptureAllowedUrls,
     kPolicyMissingMitigationMode,
     kRebootOnShutdown,
     kReleaseChannel,
     kReleaseChannelDelegated,
     kReportDeviceActivityTimes,
     kReportDeviceBootMode,
     kReportDeviceHardwareStatus,
     kReportDeviceLocation,
     kReportDeviceNetworkInterfaces,
     kReportDeviceSessionStatus,
@@ skipping 180 matching lines @@
                                     .login_screen_domain_auto_complete());
   }
 
   if (policy.has_login_authentication_behavior() &&
       policy.login_authentication_behavior()
           .has_login_authentication_behavior()) {
     new_values_cache->SetInteger(
         kLoginAuthenticationBehavior,
         policy.login_authentication_behavior().login_authentication_behavior());
   }
+
+  if (policy.has_login_video_capture_allowed_urls()) {
+    std::unique_ptr<base::ListValue> list(new base::ListValue());

[bartfab (slow), 2016/05/02 10:30:29]

Nit: #include <memory>

[Kevin Cernekee, 2016/05/02 20:02:29]

Done.

+    const em::LoginVideoCaptureAllowedUrlsProto&
+        login_video_capture_allowed_urls_proto =
+            policy.login_video_capture_allowed_urls();
+    const RepeatedPtrField<std::string>& urls =
+        login_video_capture_allowed_urls_proto.urls();
+    for (RepeatedPtrField<std::string>::const_iterator it = urls.begin();

[emaxx, 2016/05/02 18:42:08]

Nit: Can the range-based for loop be used here?

[Kevin Cernekee, 2016/05/02 20:02:29]

Done.

+         it != urls.end(); ++it) {
+      list->Append(new base::StringValue(*it));
+    }
+    new_values_cache->SetValue(kLoginVideoCaptureAllowedUrls, std::move(list));

[bartfab (slow), 2016/05/02 10:30:29]

Nit: #include <utility>

[Kevin Cernekee, 2016/05/02 20:02:29]

Done.

+  }
 }
 
 void DecodeNetworkPolicies(
     const em::ChromeDeviceSettingsProto& policy,
     PrefValueMap* new_values_cache) {
   // kSignedDataRoamingEnabled has a default value of false.
   new_values_cache->SetBoolean(
       kSignedDataRoamingEnabled,
       policy.has_data_roaming_enabled() &&
       policy.data_roaming_enabled().has_data_roaming_enabled() &&
@@ skipping 286 matching lines @@
 
     // Set the cache to the updated value.
     UpdateValuesCache(data, device_settings_, TEMPORARILY_UNTRUSTED);
 
     if (!device_settings_cache::Store(data, g_browser_process->local_state())) {
       LOG(ERROR) << "Couldn't store to the temp storage.";
       NotifyObservers(path);
       return;
     }
   }
-
 }
 
 void DeviceSettingsProvider::OwnershipStatusChanged() {
   DeviceSettingsService::OwnershipStatus new_ownership_status =
       device_settings_service_->GetOwnershipStatus();
 
   if (device_settings_service_->GetOwnerSettingsService())
     device_settings_service_->GetOwnerSettingsService()->AddObserver(this);
 
   // If the device just became owned, write the settings accumulated in the
@@ skipping 226 matching lines @@
   // Notify the observers we are done.
   std::vector<base::Closure> callbacks;
   callbacks.swap(callbacks_);
   for (size_t i = 0; i < callbacks.size(); ++i)
     callbacks[i].Run();
 
   return settings_loaded;
 }
 
 }  // namespace chromeos