Allow SAML logins to use the webcam

chrome/browser/chromeos/login/ui/webui_login_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/ui/webui_login_view.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 13 matching lines @@
 #include "chrome/browser/media/media_stream_devices_controller.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/renderer_preferences_util.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler.h"
+#include "chromeos/settings/cros_settings_names.h"
+#include "components/content_settings/core/common/content_settings_pattern.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/common/renderer_preferences.h"
@@ skipping 384 matching lines @@
   }
 
   return true;
 }
 
 void WebUILoginView::RequestMediaAccessPermission(
     WebContents* web_contents,
     const content::MediaStreamRequest& request,
     const content::MediaResponseCallback& callback) {
   MediaStreamDevicesController controller(web_contents, request, callback);
-  if (controller.IsAskingForVideo() || controller.IsAskingForAudio())
-    NOTREACHED() << "Media stream not allowed for WebUI";
+  if (controller.IsAskingForAudio() || !controller.IsAskingForVideo()) {
+    controller.PermissionDenied();

[bartfab (slow), 2016/05/02 10:30:28]

Nit: It would still make sense to have a NOTREACHED() in here for debugging
purposes.

[Kevin Cernekee, 2016/05/02 20:02:29]

It isn't a Chrome bug (i.e. assertion failure) if the site requests audio. 
We'll just deny it.

Could log a warning, although we don't log the other denials.

+    return;
+  }
+
+  chromeos::CrosSettings* settings = chromeos::CrosSettings::Get();

[bartfab (slow), 2016/05/02 10:30:28]

Nit 1: const pointer.
Nit 2: #include "chrome/browser/chromeos/settings/cros_settings.h"

[Kevin Cernekee, 2016/05/02 20:02:29]

Done.

+  if (!settings) {
+    controller.PermissionDenied();
+    return;
+  }
+
+  const base::Value* raw_types_value =

[bartfab (slow), 2016/05/02 10:30:28]

Nit: const pointer.

[Kevin Cernekee, 2016/05/02 20:02:29]

Done.

+      settings->GetPref(chromeos::kLoginVideoCaptureAllowedUrls);

[bartfab (slow), 2016/05/02 10:30:28]

Nit: s/chromeos:://

[Kevin Cernekee, 2016/05/02 20:02:29]

Done.

+  if (!raw_types_value) {
+    controller.PermissionDenied();
+    return;
+  }
+
+  const base::ListValue* types_value;
+  CHECK(raw_types_value->GetAsList(&types_value));

[bartfab (slow), 2016/05/02 10:30:28]

Nit: #include "base/logging.h"

[Kevin Cernekee, 2016/05/02 20:02:29]

Done.

+  for (size_t i = 0; i < types_value->GetSize(); ++i) {

[emaxx, 2016/05/02 18:42:08]

Nit: Range-based for loop?

[Kevin Cernekee, 2016/05/02 20:02:29]

Done.

+    std::string value;
+    if (types_value->GetString(i, &value)) {
+      ContentSettingsPattern pattern =
+          ContentSettingsPattern::FromString(value);
+      if (pattern == ContentSettingsPattern::Wildcard()) {
+        LOG(WARNING) << "Ignoring wildcard URL pattern: " << value;
+        continue;
+      }
+      if (pattern.IsValid() && pattern.Matches(request.security_origin)) {
+        controller.PermissionGranted();
+        return;
+      }
+    }
+  }
+  controller.PermissionDenied();
 }
 
 bool WebUILoginView::CheckMediaAccessPermission(
     content::WebContents* web_contents,
     const GURL& security_origin,
     content::MediaStreamType type) {
   return MediaCaptureDevicesDispatcher::GetInstance()
       ->CheckMediaAccessPermission(web_contents, security_origin, type);
 }
 
@@ skipping 46 matching lines @@
   if (should_emit_login_prompt_visible_) {
     VLOG(1) << "Login WebUI >> login-prompt-visible";
     chromeos::DBusThreadManager::Get()->GetSessionManagerClient()->
         EmitLoginPromptVisible();
   }
 
   webui_visible_ = true;
 }
 
 }  // namespace chromeos