Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1936873002: Warn about @deprecated positional parameters (Closed)

Created:
4 years, 7 months ago by srawlins
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Warn about @deprecated positional parameters BUG=https://github.com/dart-lang/sdk/issues/22975 R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/68cadb3e718a3c5b87a6b9a3ebd76dc941d95ba7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srawlins
4 years, 7 months ago (2016-05-02 15:55:45 UTC) #2
scheglov
lgtm
4 years, 7 months ago (2016-05-02 16:28:48 UTC) #3
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-02 16:43:21 UTC) #4
srawlins
4 years, 7 months ago (2016-05-02 17:34:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68cadb3e718a3c5b87a6b9a3ebd76dc941d95ba7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698