Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issue 1936853002: Assert event timestamp to be monotonic and not from future

Created:
4 years, 7 months ago by majidvp
Modified:
4 years, 2 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, blink-reviews-events_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assert event timestamp to be monotonic and not from future. Add assert in Blink Platform and Core Event type to ensure that timestamp is never larger than current monotonic clock. This helps catch any cases where we incorrectly pass wall clock timestamp. EventSender provides the ability to leap forward the time. In the past we only advance the event timestamp and left Blink monotonic clock untouched. This is no longer a viable solution given the added assumption. A better approach is to advance Blink time. Appropriate plumbing has been added to achieve this. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : Inject mock time in blink from event_sender #

Patch Set 3 : Remove 10 seconds #

Patch Set 4 : #

Patch Set 5 : Override time functions separately #

Patch Set 6 : Change to histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -51 lines) Patch
M components/test_runner/event_sender.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/event_sender.cc View 1 2 3 4 5 24 chunks +28 lines, -22 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp View 1 2 3 4 5 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/HistogramTest.cpp View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformEvent.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebTestingSupport.cpp View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 1 2 3 4 5 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/CurrentTime.h View 1 2 3 2 chunks +13 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/CurrentTime.cpp View 1 2 3 1 chunk +17 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/testing/RunAllTests.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebTestingSupport.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (8 generated)
majidvp
4 years, 7 months ago (2016-05-03 16:24:35 UTC) #4
dtapuska
4 years, 7 months ago (2016-05-12 02:02:52 UTC) #5
On 2016/05/03 16:24:35, majidvp wrote:

lgtm % tests passing.

Powered by Google App Engine
This is Rietveld 408576698