Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1936803002: Adding default_exe_manifest to 42 binaries (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding default_exe_manifest to 42 binaries gn builds are missing Windows manifests for the boringssl test binaries. These manifests are necessary in order to get predictable behavior on Windows. BUG=602505 Committed: https://crrev.com/fd6b609830987e010cf2402ecc6c66be0082a87f Cr-Commit-Position: refs/heads/master@{#390974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/boringssl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
This fixes the boringssl tests in gn builds to have the default Windows manifests. PTAL.
4 years, 7 months ago (2016-04-30 00:24:45 UTC) #2
davidben
lgtm
4 years, 7 months ago (2016-04-30 06:07:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936803002/1
4 years, 7 months ago (2016-05-02 16:17:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 17:10:21 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:12:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd6b609830987e010cf2402ecc6c66be0082a87f
Cr-Commit-Position: refs/heads/master@{#390974}

Powered by Google App Engine
This is Rietveld 408576698