Get rid of special casing for 'operator' from the bindings generator

Get rid of special casing for 'operator' from the bindings generator

Get rid of special casing for 'operator' from the bindings generator
by using [ImplementedAs=svgOperator] extended attribute for the
following attributes:
- SVGFECompositeElement.operator
- SVGFEMorphologyElement.operator

R=haraken

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154341

[haraken, 2013-07-16 15:50:05]

LGTM

Shall we add s/Svg/SVG/ to FirstLetterToUpperCase() in the code generator, and
rename setSvgOperatorBaseValue() to setSVGOperatorBaseValu() etc? This looks
like a naming convention of Blink.

[do-not-use, 2013-07-16 18:40:45]

On 2013/07/16 15:50:05, haraken wrote:
> LGTM
> 
> Shall we add s/Svg/SVG/ to FirstLetterToUpperCase() in the code generator, and
> rename setSvgOperatorBaseValue() to setSVGOperatorBaseValu() etc? This looks
> like a naming convention of Blink.

Good idea, I fixed the CL accordingly.

[commit-bot: I haz the power, 2013-07-16 18:43:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19368004/5001

[commit-bot: I haz the power, 2013-07-16 18:43:12]

Failed to apply patch for
Source/bindings/scripts/deprecated_code_generator_v8.pm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/scripts/deprecated_code_generator_v8.pm
  Hunk #1 succeeded at 5769 (offset -6 lines).
  Hunk #2 FAILED at 5832.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/bindings/scripts/deprecated_code_generator_v8.pm.rej

Patch:       Source/bindings/scripts/deprecated_code_generator_v8.pm
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm
b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index
c2aaa5667577f38d55310e70b51a383eeb9860ec..961cf4ed555c64988ffeb667ed54512346974d52
100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -5775,6 +5775,7 @@ sub FirstLetterToUpperCase
     $ret =~ s/Xml/XML/ if $ret =~ /^Xml[^a-z]/;
     $ret =~ s/Css/CSS/ if $ret =~ /^Css[^T]/;  # css -> setCSS, except
setCssText.
     $ret =~ s/Ime/IME/ if $ret =~ /^Ime/;  # ime -> setIME
+    $ret =~ s/Svg/SVG/ if $ret =~ /^Svg/;  # svg -> setSVG
     return $ret;
 }
 
@@ -5831,9 +5832,6 @@ sub AttributeNameForGetterAndSetter
     }
     my $attributeType = $attribute->type;
 
-    # Avoid clash with C++ keyword.
-    $attributeName = "_operator" if $attributeName eq "operator";
-
     # SVGAElement defines a non-virtual "String& target() const" method which
clashes with "virtual String target() const" in Element.
     # To solve this issue the SVGAElement method was renamed to "svgTarget",
take care of that when calling this method.
     $attributeName = "svgTarget" if $attributeName eq "target" and
$attributeType eq "SVGAnimatedString";

[commit-bot: I haz the power, 2013-07-16 18:58:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19368004/9001

[commit-bot: I haz the power, 2013-07-16 21:18:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19368004/19001

[commit-bot: I haz the power, 2013-07-17 00:52:28]

Change committed as 154341