Issue 19368002: Add missing links from PropertyCell to dependent_code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19368002: Add missing links from PropertyCell to dependent_code (Closed)

Created:
7 years, 5 months ago by alph

Modified:
7 years, 5 months ago

Reviewers:
yurys, danno, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add missing links from GlobalPropertyCell to dependent_code It produced orphan DependentCode nodes because links were not created explicitly in ExtractPropertyCellReferences and IndexedReferencesExtractor was disabled for ProperyCells. R=danno@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15694

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
	M	src/heap-snapshot-generator.cc	View		3 chunks	+12 lines, -11 lines	0 comments	Download
	M	test/cctest/test-heap-profiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

alph

It produced orphan DependentCode nodes because links were not created explicitly in ExtractPropertyCellReferences and IndexedReferencesExtractor ...

7 years, 5 months ago (2013-07-16 12:20:31 UTC) #1

alph

7 years, 5 months ago (2013-07-16 17:47:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r15694 (presubmit successful).