Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1936773003: DevTools: brush up command menu looks, render badges. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
caseq, paulirish
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: brush up command menu looks, render badges. BUG=608136

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Messages

Total messages: 11 (4 generated)
pfeldman
4 years, 7 months ago (2016-04-30 02:44:31 UTC) #2
caseq
https://codereview.chromium.org/1936773003/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js (right): https://codereview.chromium.org/1936773003/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js#newcode86 third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js:86: var cats = left.category().compareTo(right.category()); s/cats/dogs/?
4 years, 7 months ago (2016-04-30 02:47:26 UTC) #3
caseq
lgtm https://codereview.chromium.org/1936773003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js (right): https://codereview.chromium.org/1936773003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js#newcode151 third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js:151: titleElement.createChild("span").textContent = command.title(); nit: just createTextChild perhaps? https://codereview.chromium.org/1936773003/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js#newcode265 ...
4 years, 7 months ago (2016-05-02 17:54:57 UTC) #4
paulirish
A few style tweaks plz diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/filteredListWidget.css b/third_party/WebKit/Source/devtools/front_end/ui_lazy/filteredListWidget.css index ee768ac..0f3299b 100644 --- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/filteredListWidget.css +++ ...
4 years, 7 months ago (2016-05-02 17:59:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936773003/20001
4 years, 7 months ago (2016-05-02 17:59:56 UTC) #7
paulirish
https://codereview.chromium.org/1938053002 has the suggested changes from caseq and I
4 years, 7 months ago (2016-05-02 18:11:20 UTC) #9
pfeldman
4 years, 7 months ago (2016-05-02 18:53:10 UTC) #10 
On 2016/05/02 18:11:20, paulirish wrote:
> https://codereview.chromium.org/1938053002 has the suggested changes from
caseq
> and I

Paul stole it from me. Closing.

Powered by Google App Engine
This is Rietveld 408576698