Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: content/renderer/render_widget.cc

Issue 1936773002: Move attributes and context type out to ContextProviderCommandBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rmwgc3d
Patch Set: attributes: welglstuff Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 72573db63701fdc28305e10ff56084a396d982e0..f726939af40fad6483696827a5057e2dd696cc55 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -203,29 +203,6 @@ content::RenderWidgetInputHandlerDelegate* GetRenderWidgetInputHandlerDelegate(
return widget;
}
-std::unique_ptr<content::WebGraphicsContext3DCommandBufferImpl>
-CreateOffscreenContext(scoped_refptr<gpu::GpuChannelHost> gpu_channel_host,
- const GURL& url) {
- DCHECK(gpu_channel_host);
-
- // This is for an offscreen context for the compositor. So the default
- // framebuffer doesn't need alpha, depth, stencil, antialiasing.
- gpu::gles2::ContextCreationAttribHelper attributes;
- attributes.alpha_size = -1;
- attributes.depth_size = 0;
- attributes.stencil_size = 0;
- attributes.samples = 0;
- attributes.sample_buffers = 0;
- attributes.bind_generates_resource = false;
- attributes.lose_context_when_out_of_memory = true;
-
- bool automatic_flushes = false;
-
- return base::WrapUnique(new content::WebGraphicsContext3DCommandBufferImpl(
- gpu::kNullSurfaceHandle, url, gpu_channel_host.get(), attributes,
- gfx::PreferIntegratedGpu, automatic_flushes));
-}
-
} // namespace
namespace content {
@@ -785,11 +762,27 @@ std::unique_ptr<cc::OutputSurface> RenderWidget::CreateOutputSurface(
return nullptr;
}
+ // This is for an offscreen context for the compositor. So the default
+ // framebuffer doesn't need alpha, depth, stencil, antialiasing.
+ gpu::gles2::ContextCreationAttribHelper attributes;
+ attributes.alpha_size = -1;
+ attributes.depth_size = 0;
+ attributes.stencil_size = 0;
+ attributes.samples = 0;
+ attributes.sample_buffers = 0;
+ attributes.bind_generates_resource = false;
+ attributes.lose_context_when_out_of_memory = true;
+
+ bool automatic_flushes = false;
+
// The compositor context shares resources with the worker context.
context_provider = new ContextProviderCommandBuffer(
- CreateOffscreenContext(std::move(gpu_channel_host),
- GetURLForGraphicsContext3D()),
- limits, worker_context_provider.get(), RENDER_COMPOSITOR_CONTEXT);
+ base::WrapUnique(new content::WebGraphicsContext3DCommandBufferImpl(
+ gpu::kNullSurfaceHandle, GetURLForGraphicsContext3D(),
+ gpu_channel_host.get(), gfx::PreferIntegratedGpu,
+ automatic_flushes)),
+ limits, attributes, worker_context_provider.get(),
+ command_buffer_metrics::RENDER_COMPOSITOR_CONTEXT);
#if defined(OS_ANDROID)
if (RenderThreadImpl::current() &&

Powered by Google App Engine
This is Rietveld 408576698