content/common/gpu/client/context_provider_command_buffer.h - Issue 1936773002: Move attributes and context type out to ContextProviderCommandBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/context_provider_command_buffer.h

Issue 1936773002: Move attributes and context type out to ContextProviderCommandBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rmwgc3d

Patch Set: attributes: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/command_buffer_metrics.cc ('k') | content/common/gpu/client/context_provider_command_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/context_provider_command_buffer.h

diff --git a/content/common/gpu/client/context_provider_command_buffer.h b/content/common/gpu/client/context_provider_command_buffer.h

index 0ed79f78cebab4a90bc4a48497b9f1b58ead52d6..6ef512f82f2b9fb409d20e2f02561f3912ec5152 100644

--- a/content/common/gpu/client/context_provider_command_buffer.h

+++ b/content/common/gpu/client/context_provider_command_buffer.h

@@ -40,8 +40,9 @@ class CONTENT_EXPORT ContextProviderCommandBuffer

ContextProviderCommandBuffer(

std::unique_ptr<WebGraphicsContext3DCommandBufferImpl> context3d,

const gpu::SharedMemoryLimits& memory_limits,

+ const gpu::gles2::ContextCreationAttribHelper& attributes,

ContextProviderCommandBuffer* shared_context_provider,

- CommandBufferContextType type);

+ command_buffer_metrics::ContextType type);

gpu::CommandBufferProxyImpl* GetCommandBufferProxy();

@@ -86,8 +87,8 @@ class CONTENT_EXPORT ContextProviderCommandBuffer

std::unique_ptr<skia_bindings::GrContextForGLES2Interface> gr_context_;

gpu::SharedMemoryLimits memory_limits_;

- CommandBufferContextType context_type_;

- std::string debug_name_;

+ gpu::gles2::ContextCreationAttribHelper attributes_;

+ command_buffer_metrics::ContextType context_type_;

LostContextCallback lost_context_callback_;