Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: xfa/fxbarcode/qrcode/BC_QRDataMask.h

Issue 1936733002: Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 10 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Better names. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fxbarcode/qrcode/BC_QRDataMask.h
diff --git a/xfa/fxbarcode/qrcode/BC_QRDataMask.h b/xfa/fxbarcode/qrcode/BC_QRDataMask.h
index 88aa1140ea2b30283c9be6380f6b94016d49a643..da721e947eae11e89079d3286b1872c212f843b3 100644
--- a/xfa/fxbarcode/qrcode/BC_QRDataMask.h
+++ b/xfa/fxbarcode/qrcode/BC_QRDataMask.h
@@ -13,9 +13,9 @@ class CBC_CommonBitMatrix;
class CBC_QRDataMask {
public:
- static CFX_PtrArray* DATA_MASKS;
CBC_QRDataMask();
virtual ~CBC_QRDataMask();
Lei Zhang 2016/04/30 00:59:44 no virtual?
Tom Sepez 2016/05/02 16:20:46 Nah, this gets subclassed in a bunch of places.
+
static void Initialize();
static void Finalize();
virtual FX_BOOL IsMasked(int32_t i, int32_t j) = 0;
@@ -23,6 +23,8 @@ class CBC_QRDataMask {
static CBC_QRDataMask* ForReference(int32_t reference, int32_t& e);
static int32_t BuildDataMasks();
Lei Zhang 2016/04/30 00:59:44 Move into .cpp file in an anonymous namespace. Als
Tom Sepez 2016/05/02 16:20:46 Destroy called from elsewhere, moved static data m
static void Destroy();
+
+ static CFX_ArrayTemplate<CBC_QRDataMask*>* DATA_MASKS;
};
#endif // XFA_FXBARCODE_QRCODE_BC_QRDATAMASK_H_

Powered by Google App Engine
This is Rietveld 408576698