xfa/fxbarcode/qrcode/BC_QRDataMask.h - Issue 1936733002: Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 10

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fxbarcode/qrcode/BC_QRDataMask.h

Issue 1936733002: Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 10 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Better names. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_FXBARCODE_QRCODE_BC_QRDATAMASK_H_	7 #ifndef XFA_FXBARCODE_QRCODE_BC_QRDATAMASK_H_

8 #define XFA_FXBARCODE_QRCODE_BC_QRDATAMASK_H_	8 #define XFA_FXBARCODE_QRCODE_BC_QRDATAMASK_H_

9	9

10 #include "core/fxcrt/include/fx_basic.h"	10 #include "core/fxcrt/include/fx_basic.h"

11	11

12 class CBC_CommonBitMatrix;	12 class CBC_CommonBitMatrix;

13	13

14 class CBC_QRDataMask {	14 class CBC_QRDataMask {

15 public:	15 public:

16 static CFX_PtrArray* DATA_MASKS;

17 CBC_QRDataMask();	16 CBC_QRDataMask();

18 virtual ~CBC_QRDataMask();	17 virtual ~CBC_QRDataMask();
	Lei Zhang 2016/04/30 00:59:44 no virtual? no virtual? Tom Sepez 2016/05/02 16:20:46 Nah, this gets subclassed in a bunch of places. Show quoted text On 2016/04/30 00:59:44, Lei Zhang wrote: > no virtual? Nah, this gets subclassed in a bunch of places.
	18

19 static void Initialize();	19 static void Initialize();

20 static void Finalize();	20 static void Finalize();

21 virtual FX_BOOL IsMasked(int32_t i, int32_t j) = 0;	21 virtual FX_BOOL IsMasked(int32_t i, int32_t j) = 0;

22 void UnmaskBitMatirx(CBC_CommonBitMatrix* bits, int32_t dimension);	22 void UnmaskBitMatirx(CBC_CommonBitMatrix* bits, int32_t dimension);
	Lei Zhang 2016/04/30 00:59:44 Boo, more typos. Boo, more typos. Tom Sepez 2016/05/02 16:20:46 Done. Show quoted text On 2016/04/30 00:59:44, Lei Zhang wrote: > Boo, more typos. Done.
23 static CBC_QRDataMask* ForReference(int32_t reference, int32_t& e);	23 static CBC_QRDataMask* ForReference(int32_t reference, int32_t& e);

24 static int32_t BuildDataMasks();	24 static int32_t BuildDataMasks();
	Lei Zhang 2016/04/30 00:59:44 Move into .cpp file in an anonymous namespace. Als Move into .cpp file in an anonymous namespace. Also Destroy() and \|DATA_MASKS\|. Tom Sepez 2016/05/02 16:20:46 Destroy called from elsewhere, moved static data m Show quoted text On 2016/04/30 00:59:44, Lei Zhang wrote: > Move into .cpp file in an anonymous namespace. Also Destroy() and \|DATA_MASKS\|. Destroy called from elsewhere, moved static data member only to anon.
25 static void Destroy();	25 static void Destroy();

	26

	27 static CFX_ArrayTemplate<CBC_QRDataMask> DATA_MASKS;

26 };	28 };

27	29

28 #endif // XFA_FXBARCODE_QRCODE_BC_QRDATAMASK_H_	30 #endif // XFA_FXBARCODE_QRCODE_BC_QRDATAMASK_H_

OLD	NEW

« xfa/fxbarcode/pdf417/BC_PDF417Detector.cpp ('K') | « xfa/fxbarcode/qrcode/BC_QRDataBlock.cpp ('k') | xfa/fxbarcode/qrcode/BC_QRDataMask.cpp » ('j') | no next file with comments »