Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 10

Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 10

Committed: https://pdfium.googlesource.com/pdfium/+/8f0d0da1b12e29133fb48a778603c03bf0056124

[Tom Sepez, 2016-04-29 22:36:12]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-29 22:36:13]

Lei, part 10.

[Lei Zhang, 2016-04-29 23:55:13]

Description was changed from

==========
Replace CFX_PtryArray with typesafe CFX_ArrayTemplate, part 10
==========

to

==========
Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 10
==========

[Lei Zhang, 2016-04-30 00:59:44]

lgtm

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/pdf417/BC...
File xfa/fxbarcode/pdf417/BC_PDF417Detector.cpp (right):

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/pdf417/BC...
xfa/fxbarcode/pdf417/BC_PDF417Detector.cpp:144: column =
(int32_t)vertices->GetAt(2)->GetX();
Calculate the index and then set column/row only once?

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/qrcode/BC...
File xfa/fxbarcode/qrcode/BC_QRDataMask.h (right):

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/qrcode/BC...
xfa/fxbarcode/qrcode/BC_QRDataMask.h:17: virtual ~CBC_QRDataMask();
no virtual?

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/qrcode/BC...
xfa/fxbarcode/qrcode/BC_QRDataMask.h:22: void
UnmaskBitMatirx(CBC_CommonBitMatrix* bits, int32_t dimension);
Boo, more typos.

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/qrcode/BC...
xfa/fxbarcode/qrcode/BC_QRDataMask.h:24: static int32_t BuildDataMasks();
Move into .cpp file in an anonymous namespace. Also Destroy() and |DATA_MASKS|.

[Tom Sepez, 2016-05-02 16:20:46]

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/pdf417/BC...
File xfa/fxbarcode/pdf417/BC_PDF417Detector.cpp (right):

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/pdf417/BC...
xfa/fxbarcode/pdf417/BC_PDF417Detector.cpp:144: column =
(int32_t)vertices->GetAt(2)->GetX();
On 2016/04/30 00:59:44, Lei Zhang wrote:
> Calculate the index and then set column/row only once?
Nah, not that much simpler.

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/qrcode/BC...
File xfa/fxbarcode/qrcode/BC_QRDataMask.h (right):

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/qrcode/BC...
xfa/fxbarcode/qrcode/BC_QRDataMask.h:17: virtual ~CBC_QRDataMask();
On 2016/04/30 00:59:44, Lei Zhang wrote:
> no virtual?

Nah, this gets subclassed in a bunch of places.

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/qrcode/BC...
xfa/fxbarcode/qrcode/BC_QRDataMask.h:22: void
UnmaskBitMatirx(CBC_CommonBitMatrix* bits, int32_t dimension);
On 2016/04/30 00:59:44, Lei Zhang wrote:
> Boo, more typos.

Done.

https://codereview.chromium.org/1936733002/diff/20001/xfa/fxbarcode/qrcode/BC...
xfa/fxbarcode/qrcode/BC_QRDataMask.h:24: static int32_t BuildDataMasks();
On 2016/04/30 00:59:44, Lei Zhang wrote:
> Move into .cpp file in an anonymous namespace. Also Destroy() and
|DATA_MASKS|.

Destroy called from elsewhere, moved static data member only to anon.

[Tom Sepez, 2016-05-02 16:21:30]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-02 16:21:31]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1936733002/#ps40001
(title: "Nits")

[commit-bot: I haz the power, 2016-05-02 16:21:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936733002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936733002/40001

[commit-bot: I haz the power, 2016-05-02 16:34:39]

Description was changed from

==========
Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 10
==========

to

==========
Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 10

Committed:
https://pdfium.googlesource.com/pdfium/+/8f0d0da1b12e29133fb48a778603c03bf005...
==========

[commit-bot: I haz the power, 2016-05-02 16:34:40]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/8f0d0da1b12e29133fb48a778603c03bf005...

[Tom Sepez, 2016-05-02 17:27:39]

Lei, the end.