Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1936673002: [Extensions] Finish freezing schema (Closed)

Created:
3 years ago by Devlin
Modified:
3 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Extensions] Finish freezing schema BUG=604901 BUG=603725 BUG=591164 Review URL: https://codereview.chromium.org/1906593002 Cr-Commit-Position: refs/heads/master@{#388945} (cherry picked from commit 5fb2548448bd1b76a59d941b729d7a7f90d53bc8) Committed: https://chromium.googlesource.com/chromium/src/+/6f73ae8fbece36f9f964e2b83f893ef708cca6e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -24 lines) Patch
M chrome/renderer/resources/extensions/chrome_setting.js View 2 chunks +18 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/content_setting.js View 2 chunks +17 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/stubs_app/background.js View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/resources/binding.js View 1 chunk +11 lines, -1 line 0 comments Download
M extensions/renderer/resources/event.js View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/resources/json_schema.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/schema_utils.js View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/resources/storage_area.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/utils.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/safe_builtins.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
3 years ago (2016-04-29 20:56:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f73ae8fbece36f9f964e2b83f893ef708cca6e2.

Powered by Google App Engine
This is Rietveld 408576698