Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 193663004: The "children transform layer" needs an anchor point (Closed)

Created:
6 years, 9 months ago by Ian Vollick
Modified:
6 years, 9 months ago
Reviewers:
hartmanng, enne (OOO)
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

The "children transform layer" needs an anchor point This layer houses what used to be the sublayer transform. It needs to be applied about the layer's anchor point, so we must set it. BUG=350815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168943

Patch Set 1 #

Patch Set 2 : Need to apply the anchor point to any layer that could be the children transform layer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -0 lines) Patch
A LayoutTests/compositing/child-transform-with-anchor-point.html View 1 chunk +69 lines, -0 lines 0 comments Download
A LayoutTests/compositing/child-transform-with-anchor-point-expected.html View 1 chunk +41 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ian Vollick
6 years, 9 months ago (2014-03-11 04:43:40 UTC) #1
hartmanng
non-OWNER lgtm
6 years, 9 months ago (2014-03-11 14:48:11 UTC) #2
enne (OOO)
lgtm
6 years, 9 months ago (2014-03-11 16:59:52 UTC) #3
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 9 months ago (2014-03-11 17:01:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/193663004/20001
6 years, 9 months ago (2014-03-11 17:02:12 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 18:09:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 18:09:28 UTC) #7
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 9 months ago (2014-03-11 18:22:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/193663004/20001
6 years, 9 months ago (2014-03-11 18:23:17 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 19:59:11 UTC) #10
Message was sent while issue was closed.
Change committed as 168943

Powered by Google App Engine
This is Rietveld 408576698