remove SkWriteBuffer::getWriter32().

remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

Landing this will let us then remove SkWriter32::contiguousArray().

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1936563002

TBR=reed@google.com
Just deleting API

Committed: https://skia.googlesource.com/skia/+/b4c899d48d4c5d8e867beb611551f7b55ec60abb

[mtklein_C, 2016-04-29 16:00:13]

Description was changed from

==========
remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create
writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

BUG=skia:
==========

to

==========
remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create
writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-04-29 16:02:35]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 16:02:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936563002/1

[mtklein, 2016-04-29 16:07:27]

Description was changed from

==========
remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create
writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create
writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

Landing this will let us then remove SkWriter32::contiguousArray().

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-04-29 16:08:23]

mtklein@chromium.org changed reviewers:
+ reed@google.com
- mtklein@google.com

[commit-bot: I haz the power, 2016-04-29 16:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 16:15:30]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-04-29 16:35:41]

brianosman@google.com changed reviewers:
+ brianosman@google.com

[Brian Osman, 2016-04-29 16:35:42]

lgtm

[mtklein, 2016-04-29 17:58:55]

Description was changed from

==========
remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create
writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

Landing this will let us then remove SkWriter32::contiguousArray().

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create
writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

Landing this will let us then remove SkWriter32::contiguousArray().

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=reed@google.com
Just deleting API
==========

[mtklein, 2016-04-29 17:58:57]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-04-29 17:59:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936563002/1

[commit-bot: I haz the power, 2016-04-29 20:58:11]

Description was changed from

==========
remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create
writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

Landing this will let us then remove SkWriter32::contiguousArray().

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=reed@google.com
Just deleting API
==========

to

==========
remove SkWriteBuffer::getWriter32().

SkWriteBuffer exposes its lower-level implementation SkWriter32 through
this one call.  It's not currently used in any interesting way:
   - write_encoded_bitmap() uses it to manually re-create
writeDataAsByteArray();
   - unit tests use it incidentally as a quick way to read the serialized bytes.

This should be SkWriteBuffer no longer necessarily needs to have an SkWriter32.

Landing this will let us then remove SkWriter32::contiguousArray().

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=reed@google.com
Just deleting API

Committed:
https://skia.googlesource.com/skia/+/b4c899d48d4c5d8e867beb611551f7b55ec60abb
==========

[commit-bot: I haz the power, 2016-04-29 20:58:12]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b4c899d48d4c5d8e867beb611551f7b55ec60abb