Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 1936553002: Revert of Restores larger output buffer size when output stream requiring smaller size is closed (Closed)

Created:
4 years, 7 months ago by dvadym
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Restores larger output buffer size when output stream requiring smaller size is closed (patchset #14 id:260001 of https://codereview.chromium.org/1903753002/ ) Reason for revert: This CL breaks Asan tests on Mac 10.9: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/15389 Original issue's description: > Restores a larger output buffer size when output stream requiring smaller size is closed if > no input stream is currently using the same audio device. > > BUG=602587 > TEST=Manual tests and extra debug logging using a wide mix of audio applications (audio tag, WebAudio and WebRTC). TBR=grunell@chromium.org,olka@chromium.org,henrika@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602587 Committed: https://crrev.com/44f738f80780b75b0e1267c8be900b4cd5079d3e Cr-Commit-Position: refs/heads/master@{#390657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -147 lines) Patch
M media/audio/mac/audio_auhal_mac.h View 2 chunks +1 line, -4 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 3 chunks +0 lines, -23 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 8 chunks +1 line, -118 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dvadym
Created Revert of Restores larger output buffer size when output stream requiring smaller size is ...
4 years, 7 months ago (2016-04-29 15:45:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936553002/1
4 years, 7 months ago (2016-04-29 15:45:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 15:46:04 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:03 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44f738f80780b75b0e1267c8be900b4cd5079d3e
Cr-Commit-Position: refs/heads/master@{#390657}

Powered by Google App Engine
This is Rietveld 408576698