content/common/gpu/client/context_provider_command_buffer.h - Issue 1936503003: Collapse the initialize methods in WebGraphicsContext3DCommandBufferImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/context_provider_command_buffer.h

Issue 1936503003: Collapse the initialize methods in WebGraphicsContext3DCommandBufferImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@attributes

Patch Set: collapse: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/gpu_process_transport_factory.cc ('k') | content/common/gpu/client/context_provider_command_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/context_provider_command_buffer.h

diff --git a/content/common/gpu/client/context_provider_command_buffer.h b/content/common/gpu/client/context_provider_command_buffer.h

index 6ef512f82f2b9fb409d20e2f02561f3912ec5152..f26238069e60bb58e88703dc81ff17cab80b3410 100644

--- a/content/common/gpu/client/context_provider_command_buffer.h

+++ b/content/common/gpu/client/context_provider_command_buffer.h

@@ -82,6 +82,7 @@ class CONTENT_EXPORT ContextProviderCommandBuffer

scoped_refptr<SharedProviders> shared_providers_;

+ base::Lock context_lock_; // Referenced by context3d_.

std::unique_ptr<WebGraphicsContext3DCommandBufferImpl> context3d_;

std::unique_ptr<gpu::gles2::GLES2TraceImplementation> trace_impl_;

std::unique_ptr<skia_bindings::GrContextForGLES2Interface> gr_context_;

@@ -92,8 +93,6 @@ class CONTENT_EXPORT ContextProviderCommandBuffer

LostContextCallback lost_context_callback_;

- base::Lock context_lock_;

class LostContextCallbackProxy;

std::unique_ptr<LostContextCallbackProxy> lost_context_callback_proxy_;

};