Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1936493002:
Memory Infra: Remove memory.top_10_mobile benchmark (Closed)
DescriptionMemory Infra: Remove memory.top_10_mobile benchmark
Removing this benchmark, to be replaced with the current memory health
user story running on the top 10 mobile page set.
BUG=606361, 540022
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
Committed: https://crrev.com/16f997fbab9e601b85ee967aeb1e9b544a708742
Cr-Commit-Position: refs/heads/master@{#390695}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase (again) #
Messages
Total messages: 29 (15 generated)
Description was changed from ========== Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG=606361,540022 ========== to ========== Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG=606361,540022 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
perezju@chromium.org changed reviewers: + petrcermak@chromium.org, primiano@google.com, sullivan@chromium.org
Step 1 of the clean up plan: kill memory.top_10_mobile On a follow up CL I'll rename and switch the page set of memory health plan to use top 10 mobile.
Description was changed from ========== Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG=606361,540022 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG=606361,540022 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
perezju@chromium.org changed reviewers: + primiano@chromium.org - primiano@google.com
LGTM thanks!
LGTM. If I'm not mistaken, this will mean that there will be no memory-infra benchmarks on desktop. Is that right? Thanks, Petr
On 2016/04/29 10:09:49, petrcermak wrote: > LGTM. If I'm not mistaken, this will mean that there will be no memory-infra > benchmarks on desktop. Is that right? > > Thanks, > Petr Ah! That's true. I thought about that yesterday, but then completely forgot. There still are the LongRunningIdleGmail tests running on desktop, but no page-cycler kind of test. Primiano, are we OK with that for a while? Or should we have a separate benchmark that runs without the "background" phase?
On 2016/04/29 10:15:06, perezju wrote: > Primiano, are we OK with that for a while? Or should we have a separate > benchmark that runs without the "background" phase? Yes ok for now, we should keep this in mind before migrating the pre-memory-infra metric though :)
nednguyen@google.com changed reviewers: + nednguyen@google.com
lgtm
The CQ bit was checked by perezju@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
The CQ bit was checked by perezju@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, petrcermak@chromium.org, nednguyen@google.com Link to the patchset: https://codereview.chromium.org/1936493002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for tools/perf/benchmarks/memory_infra.py:
While running git apply --index -3 -p1;
error: patch failed: tools/perf/benchmarks/memory_infra.py:151
Falling back to three-way merge...
Applied patch to 'tools/perf/benchmarks/memory_infra.py' with conflicts.
U tools/perf/benchmarks/memory_infra.py
Patch: tools/perf/benchmarks/memory_infra.py
Index: tools/perf/benchmarks/memory_infra.py
diff --git a/tools/perf/benchmarks/memory_infra.py
b/tools/perf/benchmarks/memory_infra.py
index
4169ef84fd7a776cafbe82a6882e81f7217f8944..f82016792db1f2f84ecee05be11148a6d7528a26
100644
--- a/tools/perf/benchmarks/memory_infra.py
+++ b/tools/perf/benchmarks/memory_infra.py
@@ -151,19 +151,6 @@ class RendererMemoryBlinkMemoryMobile(_MemoryInfra):
return bool(cls._RE_RENDERER_VALUES.match(value.name))
-# Disabled on reference builds because they don't support the new
-# Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
-@benchmark.Disabled('reference')
-class MemoryBenchmarkTop10Mobile(_MemoryInfra):
- """Timeline based benchmark for measuring memory on top 10 mobile sites."""
-
- page_set = page_sets.MemoryInfraTop10MobilePageSet
-
- @classmethod
- def Name(cls):
- return 'memory.top_10_mobile'
-
-
class _MemoryV8Benchmark(_MemoryInfra):
def CreateTimelineBasedMeasurementOptions(self):
v8_categories = [
@@ -176,7 +163,6 @@ class _MemoryV8Benchmark(_MemoryInfra):
return options
-
# Disabled on reference builds because they don't support the new
# Tracing.requestMemoryDump DevTools API.
# For 'reference' see http://crbug.com/540022.
The CQ bit was unchecked by commit-bot@chromium.org
trying again! The latest attempt failed due to the revert in https://codereview.chromium.org/1935493003/
The CQ bit was checked by perezju@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, petrcermak@chromium.org, nednguyen@google.com Link to the patchset: https://codereview.chromium.org/1936493002/#ps40001 (title: "rebase (again)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936493002/40001
Message was sent while issue was closed.
Description was changed from ========== Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG=606361,540022 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG=606361,540022 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/16f997fbab9e601b85ee967aeb1e9b544a708742 Cr-Commit-Position: refs/heads/master@{#390695}
Message was sent while issue was closed.
Description was changed from ========== Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG=606361,540022 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Memory Infra: Remove memory.top_10_mobile benchmark Removing this benchmark, to be replaced with the current memory health user story running on the top 10 mobile page set. BUG=606361,540022 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/16f997fbab9e601b85ee967aeb1e9b544a708742 Cr-Commit-Position: refs/heads/master@{#390695} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
