Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1936463002: Fix invariant breakage on erroneous constant variables. (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix invariant breakage on erroneous constant variables. BUG= Committed: https://github.com/dart-lang/sdk/commit/4822bd4c0ba76f70b266c6ab31ac3c6e4d16019e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M pkg/compiler/lib/src/constants/expressions.dart View 3 chunks +15 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
4 years, 7 months ago (2016-04-29 08:51:24 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 4822bd4c0ba76f70b266c6ab31ac3c6e4d16019e (presubmit successful).
4 years, 7 months ago (2016-04-29 08:57:31 UTC) #4
Siggi Cherem (dart-lang)
4 years, 7 months ago (2016-04-29 20:24:32 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698