components/mus/surfaces/surfaces_context_provider.cc - Issue 1936423002: Remove unused locks in mus ContextProvider classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/surfaces/surfaces_context_provider.cc

Issue 1936423002: Remove unused locks in mus ContextProvider classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nit Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/surfaces/surfaces_context_provider.cc

diff --git a/components/mus/surfaces/surfaces_context_provider.cc b/components/mus/surfaces/surfaces_context_provider.cc

index ceb853b64f9d66d3faee93de051974b3ead95b35..d29295059da5eb0577eab452d4ab1d8e24ec8f4e 100644

--- a/components/mus/surfaces/surfaces_context_provider.cc

+++ b/components/mus/surfaces/surfaces_context_provider.cc

@@ -93,7 +93,9 @@ gpu::Capabilities SurfacesContextProvider::ContextCapabilities() {

void SurfacesContextProvider::SetupLock() {}

base::Lock* SurfacesContextProvider::GetLock() {

- return &context_lock_;

+ // This context provider is not used on multiple threads.

+ NOTREACEHD();

danakj 2016/05/02 22:45:20 typo

Fady Samuel 2016/05/02 22:51:37 Doh! I should've tested compiled locally first. Fi

+ return nullptr;

}

void SurfacesContextProvider::SetLostContextCallback(

« no previous file with comments | « components/mus/surfaces/surfaces_context_provider.h ('k') | no next file » | no next file with comments »