Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1936423002: Remove unused locks in mus ContextProvider classes (Closed)

Created:
4 years, 7 months ago by Fady Samuel
Modified:
4 years, 7 months ago
Reviewers:
danakj, sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused locks in mus ContextProvider classes BUG=584497 Committed: https://crrev.com/9ea37153effa7c6221608d21a53b43c5f70046f9 Cr-Commit-Position: refs/heads/master@{#391110}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed Dana's nit #

Total comments: 2

Patch Set 3 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M components/mus/public/cpp/context_provider.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/mus/public/cpp/lib/context_provider.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/surfaces/surfaces_context_provider.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
Fady Samuel
+danakj@: please review +sky@ for OWNERS
4 years, 7 months ago (2016-05-02 22:09:25 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936423002/1
4 years, 7 months ago (2016-05-02 22:10:10 UTC) #5
danakj
LGTM https://codereview.chromium.org/1936423002/diff/1/components/mus/public/cpp/lib/context_provider.cc File components/mus/public/cpp/lib/context_provider.cc (right): https://codereview.chromium.org/1936423002/diff/1/components/mus/public/cpp/lib/context_provider.cc#newcode57 components/mus/public/cpp/lib/context_provider.cc:57: return nullptr; NOTREACHED() as well and comment like ...
4 years, 7 months ago (2016-05-02 22:10:29 UTC) #6
Fady Samuel
PTAL Scott https://codereview.chromium.org/1936423002/diff/1/components/mus/public/cpp/lib/context_provider.cc File components/mus/public/cpp/lib/context_provider.cc (right): https://codereview.chromium.org/1936423002/diff/1/components/mus/public/cpp/lib/context_provider.cc#newcode57 components/mus/public/cpp/lib/context_provider.cc:57: return nullptr; On 2016/05/02 22:10:28, danakj wrote: ...
4 years, 7 months ago (2016-05-02 22:20:10 UTC) #7
sky
LGTM
4 years, 7 months ago (2016-05-02 22:40:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936423002/20001
4 years, 7 months ago (2016-05-02 22:41:49 UTC) #11
danakj
https://codereview.chromium.org/1936423002/diff/20001/components/mus/surfaces/surfaces_context_provider.cc File components/mus/surfaces/surfaces_context_provider.cc (right): https://codereview.chromium.org/1936423002/diff/20001/components/mus/surfaces/surfaces_context_provider.cc#newcode97 components/mus/surfaces/surfaces_context_provider.cc:97: NOTREACEHD(); typo
4 years, 7 months ago (2016-05-02 22:45:20 UTC) #12
Fady Samuel
CQ'ing again. https://codereview.chromium.org/1936423002/diff/20001/components/mus/surfaces/surfaces_context_provider.cc File components/mus/surfaces/surfaces_context_provider.cc (right): https://codereview.chromium.org/1936423002/diff/20001/components/mus/surfaces/surfaces_context_provider.cc#newcode97 components/mus/surfaces/surfaces_context_provider.cc:97: NOTREACEHD(); On 2016/05/02 22:45:20, danakj wrote: > ...
4 years, 7 months ago (2016-05-02 22:51:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936423002/40001
4 years, 7 months ago (2016-05-02 22:54:31 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-03 00:04:15 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 00:06:05 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9ea37153effa7c6221608d21a53b43c5f70046f9
Cr-Commit-Position: refs/heads/master@{#391110}

Powered by Google App Engine
This is Rietveld 408576698