Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1936403002: Serialize / resynthesize 'isAsynchronous' and 'isGenerator' flags. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Serialize / resynthesize 'isAsynchronous' and 'isGenerator' flags. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/339cf06a4563dd509dfca1f58be9785704a0694b

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -19 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 12 chunks +51 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +12 lines, -0 lines 3 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 2 chunks +0 lines, -18 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +32 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 11 chunks +62 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-05-02 21:27:45 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1936403002/diff/1/pkg/analyzer/lib/src/summary/idl.dart File pkg/analyzer/lib/src/summary/idl.dart (right): https://codereview.chromium.org/1936403002/diff/1/pkg/analyzer/lib/src/summary/idl.dart#newcode1676 pkg/analyzer/lib/src/summary/idl.dart:1676: bool get isAsynchronous; This should be marked as ...
4 years, 7 months ago (2016-05-02 21:49:30 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 339cf06a4563dd509dfca1f58be9785704a0694b (presubmit successful).
4 years, 7 months ago (2016-05-02 21:52:27 UTC) #4
scheglov
4 years, 7 months ago (2016-05-02 21:52:56 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1936403002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1936403002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:1676: bool get isAsynchronous;
On 2016/05/02 21:49:30, Paul Berry wrote:
> This should be marked as "@informative", since it doesn't affect the API of
the
> code being analyzed.

Done.

Powered by Google App Engine
This is Rietveld 408576698