Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: test/mjsunit/harmony/array-species-constructor.js

Issue 1936393002: Make array __proto__ manipulations not disturb the species protector (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix review issues Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-test.cc ('k') | test/mjsunit/harmony/array-species-constructor-accessor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/array-species-constructor.js
diff --git a/test/mjsunit/harmony/array-species-constructor.js b/test/mjsunit/harmony/array-species-constructor.js
index d4eeefa010bd987ce960a982d3c2b3604049a266..d766e09eee058862527bb31b45c90a53be183099 100644
--- a/test/mjsunit/harmony/array-species-constructor.js
+++ b/test/mjsunit/harmony/array-species-constructor.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --harmony-species
+// Flags: --harmony-species --allow-natives-syntax
// Overwriting the constructor of an instance updates the protector
@@ -18,6 +18,7 @@ assertEquals(1, x.concat([1])[0]);
class MyArray extends Array { }
x.constructor = MyArray;
+assertFalse(%SpeciesProtector());
Camillo Bruni 2016/05/11 12:50:08 nit: could you also check that the SpeciesProtecto
Dan Ehrenberg 2016/05/11 14:32:16 No because apparently 'stress' runs happen multipl
assertEquals(MyArray, x.map(()=>{}).constructor);
assertEquals(MyArray, x.filter(()=>{}).constructor);
« no previous file with comments | « src/runtime/runtime-test.cc ('k') | test/mjsunit/harmony/array-species-constructor-accessor.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698