Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: src/objects-inl.h

Issue 1936393002: Make array __proto__ manipulations not disturb the species protector (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tests, cleanup Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 60a140b79c58f0fda45e1126dc97d0669ed142c0..72f7c8ad73f2c74c779ce7a66a659e4adf884a93 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -2261,7 +2261,6 @@ void Struct::InitializeBody(int object_size) {
}
}
-
bool Object::ToArrayLength(uint32_t* index) { return Object::ToUint32(index); }
@@ -7586,6 +7585,11 @@ void JSArray::SetContent(Handle<JSArray> array,
}
+bool JSArray::HasArrayPrototype(Isolate* isolate) {
adamk 2016/05/03 00:45:31 You don't need to pass in the isolate, since JSArr
Camillo Bruni 2016/05/03 08:05:53 not sure what the performance impact is though. si
+ return map()->prototype() == isolate->context()->initial_array_prototype();
adamk 2016/05/03 00:45:31 This should be coming off the native_context(). Bu
Dan Ehrenberg 2016/05/04 00:18:50 Done
+}
+
+
int TypeFeedbackInfo::ic_total_count() {
int current = Smi::cast(READ_FIELD(this, kStorage1Offset))->value();
return ICTotalCountField::decode(current);

Powered by Google App Engine
This is Rietveld 408576698