Make array __proto__ manipulations not disturb the species protector

src/objects-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Review notes:
 //
 // - The use of macros in these inline functions may seem superfluous
 // but it is absolutely needed to make sure gcc generates optimal
 // code. gcc is not happy when attempting to inline too deep.
 //
@@ skipping 2243 matching lines @@
 }
 
 
 void Struct::InitializeBody(int object_size) {
   Object* value = GetHeap()->undefined_value();
   for (int offset = kHeaderSize; offset < object_size; offset += kPointerSize) {
     WRITE_FIELD(this, offset, value);
   }
 }
 
-
 bool Object::ToArrayLength(uint32_t* index) { return Object::ToUint32(index); }
 
 
 bool Object::ToArrayIndex(uint32_t* index) {
   return Object::ToUint32(index) && *index != kMaxUInt32;
 }
 
 
 void Object::VerifyApiCallResultType() {
 #if DEBUG
@@ skipping 5304 matching lines @@
           IsFastDoubleElementsKind(array->GetElementsKind())) ||
          ((storage->map() != array->GetHeap()->fixed_double_array_map()) &&
           (IsFastObjectElementsKind(array->GetElementsKind()) ||
            (IsFastSmiElementsKind(array->GetElementsKind()) &&
             Handle<FixedArray>::cast(storage)->ContainsOnlySmisOrHoles()))));
   array->set_elements(*storage);
   array->set_length(Smi::FromInt(storage->length()));
 }
 
 
+bool JSArray::HasArrayPrototype(Isolate* isolate) {

[adamk, 2016/05/03 00:45:31]

You don't need to pass in the isolate, since JSArray already knows the Isolate.
Just call GetIsolate().

[Camillo Bruni, 2016/05/03 08:05:53]

not sure what the performance impact is though. since in the places this is used
we have the isolate at hand i don't see it that much as a problem.

+  return map()->prototype() == isolate->context()->initial_array_prototype();

[adamk, 2016/05/03 00:45:31]

This should be coming off the native_context(). But you should be able to just
use

GetIsolate()->initial_array_prototype()

(defined in a macro in isolates-inl.h)

[Dan Ehrenberg, 2016/05/04 00:18:50]

Done

+}
+
+
 int TypeFeedbackInfo::ic_total_count() {
   int current = Smi::cast(READ_FIELD(this, kStorage1Offset))->value();
   return ICTotalCountField::decode(current);
 }
 
 
 void TypeFeedbackInfo::set_ic_total_count(int count) {
   int value = Smi::cast(READ_FIELD(this, kStorage1Offset))->value();
   value = ICTotalCountField::update(value,
                                     ICTotalCountField::decode(count));
@@ skipping 252 matching lines @@
 #undef WRITE_INT64_FIELD
 #undef READ_BYTE_FIELD
 #undef WRITE_BYTE_FIELD
 #undef NOBARRIER_READ_BYTE_FIELD
 #undef NOBARRIER_WRITE_BYTE_FIELD
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_OBJECTS_INL_H_