Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1936383002: Remove std::string usage in PublicMethods.cpp. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove std::string usage in PublicMethods.cpp. BUG=pdfium:488 Committed: https://pdfium.googlesource.com/pdfium/+/cf03f8ee46e66e244bbe57d34c8667e5edc455b3

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -90 lines) Patch
M fpdfsdk/javascript/PublicMethods.cpp View 1 2 3 14 chunks +58 lines, -90 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-05-03 17:53:56 UTC) #2
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-03 18:23:13 UTC) #3
Tom Sepez
https://codereview.chromium.org/1936383002/diff/20001/fpdfsdk/javascript/PublicMethods.cpp File fpdfsdk/javascript/PublicMethods.cpp (right): https://codereview.chromium.org/1936383002/diff/20001/fpdfsdk/javascript/PublicMethods.cpp#newcode903 fpdfsdk/javascript/PublicMethods.cpp:903: CFX_WideString w_strValue = val; nit: can we lose the ...
4 years, 7 months ago (2016-05-03 23:34:30 UTC) #4
Lei Zhang
https://codereview.chromium.org/1936383002/diff/20001/fpdfsdk/javascript/PublicMethods.cpp File fpdfsdk/javascript/PublicMethods.cpp (right): https://codereview.chromium.org/1936383002/diff/20001/fpdfsdk/javascript/PublicMethods.cpp#newcode903 fpdfsdk/javascript/PublicMethods.cpp:903: CFX_WideString w_strValue = val; On 2016/05/03 23:34:30, Tom Sepez ...
4 years, 7 months ago (2016-05-09 19:22:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936383002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936383002/60001
4 years, 7 months ago (2016-05-09 19:22:47 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 19:36:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/cf03f8ee46e66e244bbe57d34c8667e5edc4...

Powered by Google App Engine
This is Rietveld 408576698