Add a flag to not start GPU process on browser startup

Add a flag to not start GPU process on browser startup

There is no need to start GPU process if user resumes a download in background.
In this case, we only need to launch the browser process.
The GPU process will be automatically created when user relaunches
chrome app.

BUG=608451
Committed: https://crrev.com/e1b968066f2e59bbc6f28f3ed5cbd3ba719d699b
Cr-Commit-Position: refs/heads/master@{#391937}

[qinmin, 2016-05-02 20:34:05]

qinmin@chromium.org changed reviewers:
+ creis@chromium.org, tedchoc@chromium.org

[qinmin, 2016-05-02 20:34:05]

PTAL

[qinmin, 2016-05-03 17:04:09]

qinmin@chromium.org changed reviewers:
+ yfriedman@chromium.org
- tedchoc@chromium.org

[qinmin, 2016-05-03 17:04:10]

Ted is OOO, + yfriedman for code review

[Yaron, 2016-05-03 18:03:10]

Can you elaborate on how the GPU process ends up getting started when you go to
the activity?

Doing this as a command-line flag feels a bit wrong - I'm wondering if there's a
different way that's less like a static global. Perhaps there's too many layers
to traverse though

[qinmin, 2016-05-03 22:53:38]

On 2016/05/03 18:03:10, Yaron wrote:
> Can you elaborate on how the GPU process ends up getting started when you go
to
> the activity?
> 
> Doing this as a command-line flag feels a bit wrong - I'm wondering if there's
a
> different way that's less like a static global. Perhaps there's too many
layers
> to traverse though

When relaunching Chrome, CompositorImpl::RequestNewOutputSurface() will recreate
the GPU channel since it is not created when browser starts.

An alternative to command-line is to use BrowserStartupController. If you prefer
that over the commandline, i can switch to that instead.

[qinmin, 2016-05-04 17:45:11]

ok, added a new method in BrowserStartupController to avoid introducing the new
commandline flag.

[Yaron, 2016-05-05 00:32:59]

lgtm

https://codereview.chromium.org/1936353002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/1936353002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:323:
public boolean willStartGpuProcess() {
s/will/should/

[qinmin, 2016-05-05 16:49:57]

https://codereview.chromium.org/1936353002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/1936353002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:323:
public boolean willStartGpuProcess() {
On 2016/05/05 00:32:59, Yaron wrote:
> s/will/should/

Done.

[Charlie Reis, 2016-05-05 16:55:00]

content/ LGTM with nit.

https://codereview.chromium.org/1936353002/diff/40001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/1936353002/diff/40001/content/browser/browser...
content/browser/browser_main_loop.cc:1249: always_uses_gpu =
StartGpuProcessOnBrowserStartup();
This sounds like a command to start the GPU process.  Please rename to
ShouldStartGpuProcessOnBrowserStartup (similar to Yaron's request).

[qinmin, 2016-05-05 17:05:53]

https://codereview.chromium.org/1936353002/diff/40001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/1936353002/diff/40001/content/browser/browser...
content/browser/browser_main_loop.cc:1249: always_uses_gpu =
StartGpuProcessOnBrowserStartup();
On 2016/05/05 16:55:00, Charlie Reis wrote:
> This sounds like a command to start the GPU process.  Please rename to
> ShouldStartGpuProcessOnBrowserStartup (similar to Yaron's request).

Done.

[qinmin, 2016-05-05 17:07:22]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-05-05 17:07:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org, creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1936353002/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-05-05 17:07:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936353002/60001

[commit-bot: I haz the power, 2016-05-05 17:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 17:22:14]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[qinmin, 2016-05-05 19:07:34]

Patchset #4 (id:60001) has been deleted

[qinmin, 2016-05-05 19:07:39]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-05-05 19:07:39]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1936353002/#ps80001
(title: "nit")

[commit-bot: I haz the power, 2016-05-05 19:08:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936353002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936353002/80001

[commit-bot: I haz the power, 2016-05-05 19:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 19:29:02]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[qinmin, 2016-05-05 19:34:38]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-05-05 19:34:39]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1936353002/#ps100001
(title: "fix ContentShellTestApk")

[commit-bot: I haz the power, 2016-05-05 19:35:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936353002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936353002/100001

[commit-bot: I haz the power, 2016-05-05 20:07:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 20:07:44]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[qinmin, 2016-05-05 21:26:50]

Patchset #5 (id:100001) has been deleted

[qinmin, 2016-05-05 21:26:57]

Patchset #5 (id:120001) has been deleted

[qinmin, 2016-05-05 21:27:04]

The CQ bit was checked by qinmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 21:27:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936353002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936353002/140001

[qinmin, 2016-05-05 22:18:59]

The CQ bit was unchecked by qinmin@chromium.org

[qinmin, 2016-05-05 22:19:02]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-05-05 22:19:02]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1936353002/#ps140001
(title: "fix ContentShellTestApk")

[commit-bot: I haz the power, 2016-05-05 22:19:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936353002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936353002/140001

[commit-bot: I haz the power, 2016-05-05 23:00:29]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-05-05 23:02:00]

Description was changed from

==========
Add a flag to not start GPU process on browser startup

There is no need to start GPU process if user resumes a download in background.
In this case, we only need to launch the browser process.
The GPU process will be automatically created when user relaunches
chrome app.

BUG=608451
==========

to

==========
Add a flag to not start GPU process on browser startup

There is no need to start GPU process if user resumes a download in background.
In this case, we only need to launch the browser process.
The GPU process will be automatically created when user relaunches
chrome app.

BUG=608451

Committed: https://crrev.com/e1b968066f2e59bbc6f28f3ed5cbd3ba719d699b
Cr-Commit-Position: refs/heads/master@{#391937}
==========

[commit-bot: I haz the power, 2016-05-05 23:02:01]

Patchset 5 (id:??) landed as
https://crrev.com/e1b968066f2e59bbc6f28f3ed5cbd3ba719d699b
Cr-Commit-Position: refs/heads/master@{#391937}