[mojo-edk] Fix uninitialized reads in EDK dispatchers

mojo/edk/system/message_pipe_dispatcher.cc

Index: mojo/edk/system/message_pipe_dispatcher.cc
diff --git a/mojo/edk/system/message_pipe_dispatcher.cc b/mojo/edk/system/message_pipe_dispatcher.cc
index d55a3c975cea1312c2fd3c6bbbcd8435a1fa72da..8d456c967c662c53a4c31a6a2eadf772d853d72d 100644
--- a/mojo/edk/system/message_pipe_dispatcher.cc
+++ b/mojo/edk/system/message_pipe_dispatcher.cc
@@ -499,7 +499,9 @@ void MessagePipeDispatcher::OnPortStatusChanged() {
 
 #if !defined(NDEBUG)
   ports::PortStatus port_status;
-  node_controller_->node()->GetStatus(port_, &port_status);
+  if (node_controller_->node()->GetStatus(port_, &port_status) != ports::OK)

[Anand Mistry (off Chromium), 2016/05/03 05:51:54]

Now debug and non-debug builds have different semantics (because of the awake
below the #if), which is bad for testing. Either zero-initalise port_status, or
encapsulate the entire block below in a condition.

[Ken Rockot(use gerrit already), 2016/05/03 06:16:15]

Good catch, fixed

+    return;
+
   if (port_status.has_messages) {
     ports::ScopedMessage unused;
     size_t message_size = 0;