Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: mojo/edk/system/data_pipe_consumer_dispatcher.cc

Issue 1936333002: [mojo-edk] Fix uninitialized reads in EDK dispatchers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/edk/system/data_pipe_producer_dispatcher.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/edk/system/data_pipe_consumer_dispatcher.h" 5 #include "mojo/edk/system/data_pipe_consumer_dispatcher.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 500 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 UpdateSignalsStateNoLock(); 511 UpdateSignalsStateNoLock();
512 } 512 }
513 513
514 void DataPipeConsumerDispatcher::UpdateSignalsStateNoLock() { 514 void DataPipeConsumerDispatcher::UpdateSignalsStateNoLock() {
515 lock_.AssertAcquired(); 515 lock_.AssertAcquired();
516 516
517 bool was_peer_closed = peer_closed_; 517 bool was_peer_closed = peer_closed_;
518 size_t previous_bytes_available = bytes_available_; 518 size_t previous_bytes_available = bytes_available_;
519 519
520 ports::PortStatus port_status; 520 ports::PortStatus port_status;
521 if (node_controller_->node()->GetStatus(control_port_, &port_status) != 521 int rv = node_controller_->node()->GetStatus(control_port_, &port_status);
522 ports::OK || 522 if (rv != ports::OK || !port_status.receiving_messages) {
523 !port_status.receiving_messages) {
524 DVLOG(1) << "Data pipe consumer " << pipe_id_ << " is aware of peer closure" 523 DVLOG(1) << "Data pipe consumer " << pipe_id_ << " is aware of peer closure"
525 << " [control_port=" << control_port_.name() << "]"; 524 << " [control_port=" << control_port_.name() << "]";
526
527 peer_closed_ = true; 525 peer_closed_ = true;
528 } 526 } else if (rv == ports::OK && port_status.has_messages && !in_transit_) {
529
530 if (port_status.has_messages && !in_transit_) {
531 ports::ScopedMessage message; 527 ports::ScopedMessage message;
532 do { 528 do {
533 int rv = node_controller_->node()->GetMessageIf(control_port_, nullptr, 529 int rv = node_controller_->node()->GetMessageIf(control_port_, nullptr,
534 &message); 530 &message);
535 if (rv != ports::OK) 531 if (rv != ports::OK)
536 peer_closed_ = true; 532 peer_closed_ = true;
537 if (message) { 533 if (message) {
538 const DataPipeControlMessage* m = 534 const DataPipeControlMessage* m =
539 static_cast<const DataPipeControlMessage*>( 535 static_cast<const DataPipeControlMessage*>(
540 message->payload_bytes()); 536 message->payload_bytes());
(...skipping 21 matching lines...) Expand all
562 } 558 }
563 559
564 if (peer_closed_ != was_peer_closed || 560 if (peer_closed_ != was_peer_closed ||
565 bytes_available_ != previous_bytes_available) { 561 bytes_available_ != previous_bytes_available) {
566 awakable_list_.AwakeForStateChange(GetHandleSignalsStateNoLock()); 562 awakable_list_.AwakeForStateChange(GetHandleSignalsStateNoLock());
567 } 563 }
568 } 564 }
569 565
570 } // namespace edk 566 } // namespace edk
571 } // namespace mojo 567 } // namespace mojo
OLDNEW
« no previous file with comments | « no previous file | mojo/edk/system/data_pipe_producer_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698