Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1936313003: Fix async test failures (Closed)

Created:
4 years, 7 months ago by Leaf
Modified:
4 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix async test failures. Remove test accidentally duplicated into the non-error path. TBR=floitsch@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bd323f27cdc128b79ed27a7d6af65d20ff2f94be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M sdk/lib/async/future_impl.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Leaf
4 years, 7 months ago (2016-05-02 18:59:14 UTC) #3
Leaf
Committed patchset #1 (id:1) manually as bd323f27cdc128b79ed27a7d6af65d20ff2f94be (presubmit successful).
4 years, 7 months ago (2016-05-02 18:59:43 UTC) #5
floitsch
4 years, 7 months ago (2016-05-02 19:17:21 UTC) #6
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698