Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1936283003: documentation: SkDocument::MakePDF() (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2016-05-02 (Monday) 17:27:37 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M samplecode/SampleApp.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M site/user/api/canvas.md View 8 chunks +18 lines, -17 lines 0 comments Download
M site/user/sample/pdf.md View 1 chunk +16 lines, -13 lines 0 comments Download
M src/utils/SkLua.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/fiddle/fiddle_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skhello.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936283003/20001
4 years, 7 months ago (2016-05-02 21:28:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 21:40:42 UTC) #6
hal.canary
PTAL
4 years, 7 months ago (2016-05-03 14:25:40 UTC) #8
tomhudson
lgtm
4 years, 7 months ago (2016-05-03 18:04:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936283003/20001
4 years, 7 months ago (2016-05-03 19:04:18 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 19:10:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/676ab68b04597c997e3152f31c08090c0d2ccbe4

Powered by Google App Engine
This is Rietveld 408576698