[heap] Fine-grained JSArrayBuffer tracking

[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=chromium:581412
LOG=N
R=jochen@chromium.org, hpayer@chromium.org

Committed: https://crrev.com/4cdf71e2d07c038d7af84e41c6e6d0093af0f0de
Cr-Commit-Position: refs/heads/master@{#36140}

[Michael Lippautz, 2016-05-06 09:57:36]

Description was changed from

==========
[heap] ArrayBufferTracker 2nd

BUG=
==========

to

==========
[heap] Page-based JSArrayBuffer tracking

BUG=
==========

[Michael Lippautz, 2016-05-09 11:46:43]

Description was changed from

==========
[heap] Page-based JSArrayBuffer tracking

BUG=
==========

to

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=
==========

[Michael Lippautz, 2016-05-09 11:46:43]

Description was changed from

==========
[heap] Page-based JSArrayBuffer tracking

BUG=
==========

to

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=
==========

[Michael Lippautz, 2016-05-09 11:47:11]

Description was changed from

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=
==========

to

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=
==========

[Michael Lippautz, 2016-05-09 11:47:40]

Description was changed from

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=
==========

to

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=chromium:581412
LOG=N
==========

[Michael Lippautz, 2016-05-09 11:50:35]

Patchset #6 (id:100001) has been deleted

[Michael Lippautz, 2016-05-09 11:50:40]

Patchset #5 (id:80001) has been deleted

[Michael Lippautz, 2016-05-09 11:55:18]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 11:55:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936233002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936233002/120001

[commit-bot: I haz the power, 2016-05-09 12:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 12:15:51]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1315)
  v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Michael Lippautz, 2016-05-09 14:54:17]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 14:54:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936233002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936233002/140001

[commit-bot: I haz the power, 2016-05-09 15:10:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 15:10:52]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1327)
  v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Michael Lippautz, 2016-05-09 15:54:10]

Patchset #2 (id:20001) has been deleted

[Michael Lippautz, 2016-05-09 15:54:16]

Patchset #2 (id:40001) has been deleted

[Michael Lippautz, 2016-05-09 15:54:24]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 15:54:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936233002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936233002/160001

[commit-bot: I haz the power, 2016-05-09 16:11:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 16:11:43]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1330)
  v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Michael Lippautz, 2016-05-09 16:35:31]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[Michael Lippautz, 2016-05-09 16:35:41]

Patchset #5 (id:160001) has been deleted

[commit-bot: I haz the power, 2016-05-09 16:35:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936233002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936233002/180001

[Michael Lippautz, 2016-05-09 17:07:26]

Description was changed from

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=chromium:581412
LOG=N
==========

to

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=chromium:581412
LOG=N
R=jochen@chromium.org, hpayer@chromium.org
==========

[Michael Lippautz, 2016-05-09 17:09:13]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org, jochen@chromium.org

[Michael Lippautz, 2016-05-09 17:09:14]

ptal

https://codereview.chromium.org/1936233002/diff/180001/src/heap/array-buffer-...
File src/heap/array-buffer-tracker.h (right):

https://codereview.chromium.org/1936233002/diff/180001/src/heap/array-buffer-...
src/heap/array-buffer-tracker.h:54: void IterateNotYetDiscoveredEntries(ListType
list, Key from, Key to,
This one will be used during moving pages within the young gen.

https://codereview.chromium.org/1936233002/diff/180001/src/heap/heap.cc
File src/heap/heap.cc (left):

https://codereview.chromium.org/1936233002/diff/180001/src/heap/heap.cc#oldco...
src/heap/heap.cc:1629: array_buffer_tracker()->PrepareDiscoveryInNewSpace();
RegisterNew now creates a state that is compatible with scavenging and MC, so no
more special handling here.

https://codereview.chromium.org/1936233002/diff/180001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1936233002/diff/180001/src/heap/mark-compact....
src/heap/mark-compact.cc:1679: reinterpret_cast<JSArrayBuffer*>(object));
We cannot use ::cast() for old_buffer (the 2nd parameter) as we already wrote
the fwd pointer.

https://codereview.chromium.org/1936233002/diff/180001/test/cctest/heap/test-...
File test/cctest/heap/test-array-buffer-tracker.cc (right):

https://codereview.chromium.org/1936233002/diff/180001/test/cctest/heap/test-...
test/cctest/heap/test-array-buffer-tracker.cc:33: // The following tests make
sure that JSArrayBuffer tracking works expected when
It's dangerous to go alone! Take this.

[commit-bot: I haz the power, 2016-05-09 17:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 17:10:36]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-05-10 11:19:04]

lgtm

https://codereview.chromium.org/1936233002/diff/180001/src/heap/array-buffer-...
File src/heap/array-buffer-tracker.h (right):

https://codereview.chromium.org/1936233002/diff/180001/src/heap/array-buffer-...
src/heap/array-buffer-tracker.h:92: 
drop the newline

[Michael Lippautz, 2016-05-10 12:12:33]

https://codereview.chromium.org/1936233002/diff/180001/src/heap/array-buffer-...
File src/heap/array-buffer-tracker.h (right):

https://codereview.chromium.org/1936233002/diff/180001/src/heap/array-buffer-...
src/heap/array-buffer-tracker.h:92: 
On 2016/05/10 11:19:04, Hannes Payer wrote:
> drop the newline

Done.

[Michael Lippautz, 2016-05-10 12:13:01]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-05-10 12:13:01]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1936233002/#ps200001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-05-10 12:13:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936233002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936233002/200001

[commit-bot: I haz the power, 2016-05-10 12:46:26]

Description was changed from

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=chromium:581412
LOG=N
R=jochen@chromium.org, hpayer@chromium.org
==========

to

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=chromium:581412
LOG=N
R=jochen@chromium.org, hpayer@chromium.org
==========

[commit-bot: I haz the power, 2016-05-10 12:46:27]

Committed patchset #7 (id:200001)

[commit-bot: I haz the power, 2016-05-10 12:48:12]

Description was changed from

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=chromium:581412
LOG=N
R=jochen@chromium.org, hpayer@chromium.org
==========

to

==========
[heap] Fine-grained JSArrayBuffer tracking

Track based on JSArrayBuffer addresses instead of the attached backing store.
This way we can later on iterate buffers on a single page.

BUG=chromium:581412
LOG=N
R=jochen@chromium.org, hpayer@chromium.org

Committed: https://crrev.com/4cdf71e2d07c038d7af84e41c6e6d0093af0f0de
Cr-Commit-Position: refs/heads/master@{#36140}
==========

[commit-bot: I haz the power, 2016-05-10 12:48:14]

Patchset 7 (id:??) landed as
https://crrev.com/4cdf71e2d07c038d7af84e41c6e6d0093af0f0de
Cr-Commit-Position: refs/heads/master@{#36140}

[Michael Lippautz, 2016-05-10 13:29:06]

A revert of this CL (patchset #7 id:200001) has been created in
https://codereview.chromium.org/1961403002/ by mlippautz@chromium.org.

The reason for reverting is: Breaks readonly test
 
https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux/builds/1....

[Michael Achenbach, 2016-05-10 13:39:12]

Also runs into a dcheck:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds...