Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 193623002: Use new is*Element() helper functions more in core/ code (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Use new is*Element() helper functions more in core/ code Use new is*Element() helpers more in core/ code. This makes the code clearer and simpler. R=eseidel, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M Source/core/clipboard/Clipboard.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/FormSubmission.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/plugins/PluginOcclusionSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 11 chunks +28 lines, -27 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 9 months ago (2014-03-11 00:46:05 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-11 19:29:41 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-11 19:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/193623002/1
6 years, 9 months ago (2014-03-11 19:31:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 20:45:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 20:45:06 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-11 22:41:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/193623002/1
6 years, 9 months ago (2014-03-11 22:41:21 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 02:25:58 UTC) #9
Message was sent while issue was closed.
Change committed as 168969

Powered by Google App Engine
This is Rietveld 408576698