Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1936223002: Refactors MultiWindowResizeController to use ash/wm/common (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactors MultiWindowResizeController to use ash/wm/common BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef Cr-Commit-Position: refs/heads/master@{#391050}

Patch Set 1 #

Patch Set 2 : nullptr #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -963 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/aura/wm_root_window_controller_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_root_window_controller_aura.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M ash/wm/common/wm_root_window_controller.h View 2 chunks +11 lines, -0 lines 0 comments Download
A + ash/wm/common/workspace/multi_window_resize_controller.h View 7 chunks +19 lines, -22 lines 0 comments Download
A + ash/wm/common/workspace/multi_window_resize_controller.cc View 1 19 chunks +114 lines, -159 lines 3 comments Download
D ash/wm/workspace/multi_window_resize_controller.h View 1 chunk +0 lines, -183 lines 0 comments Download
D ash/wm/workspace/multi_window_resize_controller.cc View 1 chunk +0 lines, -585 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sky
4 years, 7 months ago (2016-05-02 16:45:23 UTC) #1
James Cook
LGTM https://codereview.chromium.org/1936223002/diff/20001/ash/wm/common/workspace/multi_window_resize_controller.cc File ash/wm/common/workspace/multi_window_resize_controller.cc (right): https://codereview.chromium.org/1936223002/diff/20001/ash/wm/common/workspace/multi_window_resize_controller.cc#newcode377 ash/wm/common/workspace/multi_window_resize_controller.cc:377: params.name = "MultiWindowResizeController"; Hooray for names via InitParams! ...
4 years, 7 months ago (2016-05-02 19:12:45 UTC) #2
sky
https://codereview.chromium.org/1936223002/diff/20001/ash/wm/common/workspace/multi_window_resize_controller.cc File ash/wm/common/workspace/multi_window_resize_controller.cc (right): https://codereview.chromium.org/1936223002/diff/20001/ash/wm/common/workspace/multi_window_resize_controller.cc#newcode381 ash/wm/common/workspace/multi_window_resize_controller.cc:381: ->ConfigureWidgetInitParamsForContainer( On 2016/05/02 19:12:45, James Cook wrote: > Out ...
4 years, 7 months ago (2016-05-02 21:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936223002/20001
4 years, 7 months ago (2016-05-02 21:01:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 21:15:51 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 21:16:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef
Cr-Commit-Position: refs/heads/master@{#391050}

Powered by Google App Engine
This is Rietveld 408576698