Clean up SkFontConfigInterface implementation.

Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typefaces with the FCI instance which provides its identity.

Simplifies the singleton initialization.

Committed: https://skia.googlesource.com/skia/+/0265707c191a31dfde08dd1cd7011c1fe5b8e643

[bungeman-skia, 2016-05-02 16:30:57]

Description was changed from

==========
Clean up SkFontConfigInterface implementation.
==========

to

==========
Clean up SkFontConfigInterface implementation.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-05-02 16:31:18]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 16:31:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936213002/1

[bungeman-skia, 2016-05-02 16:35:18]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-05-02 16:43:11]

Description was changed from

==========
Clean up SkFontConfigInterface implementation.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typeface with FCI instance which provides that identity.

Simplifies the singleton initialization.


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-05-02 17:23:36]

Description was changed from

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typeface with FCI instance which provides that identity.

Simplifies the singleton initialization.


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typeface with FCI instance which provides that identity.

Simplifies the singleton initialization.
==========

[bungeman-skia, 2016-05-02 17:26:45]

Description was changed from

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typeface with FCI instance which provides that identity.

Simplifies the singleton initialization.
==========

to

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typefaces with the FCI instance which provides its identity.

Simplifies the singleton initialization.
==========

[bungeman-skia, 2016-05-02 17:28:24]

bungeman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[bungeman-skia, 2016-05-02 17:28:24]

This mostly moves code around in order to make the control flow less confusing.
Along the way it makes it easier to fix various long standing issues.

[reed1, 2016-05-02 17:32:10]

lgtm

[bungeman-skia, 2016-05-02 18:35:41]

Description was changed from

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typefaces with the FCI instance which provides its identity.

Simplifies the singleton initialization.
==========

to

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typefaces with the FCI instance which provides its identity.

Simplifies the singleton initialization.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-05-02 18:36:00]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 18:36:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936213002/20001

[bungeman-skia, 2016-05-02 18:46:07]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-05-02 18:46:21]

Description was changed from

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typefaces with the FCI instance which provides its identity.

Simplifies the singleton initialization.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typefaces with the FCI instance which provides its identity.

Simplifies the singleton initialization.
==========

[bungeman-skia, 2016-05-02 18:46:46]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2016-05-02 18:46:46]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1936213002/#ps20001
(title: "SkOnce")

[commit-bot: I haz the power, 2016-05-02 18:47:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1936213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1936213002/20001

[commit-bot: I haz the power, 2016-05-02 18:54:15]

Description was changed from

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typefaces with the FCI instance which provides its identity.

Simplifies the singleton initialization.
==========

to

==========
Clean up SkFontConfigInterface implementation.

Renames some classes to avoid confusion with FontConfig.

Removed direct calls to FontConfig instead of calling FCI.

Moves the globals and factory to one (optional) file.

Moves font management code from typeface to font manager.

Adds index to fonts created from streams.

Associates FCI typefaces with the FCI instance which provides its identity.

Simplifies the singleton initialization.

Committed:
https://skia.googlesource.com/skia/+/0265707c191a31dfde08dd1cd7011c1fe5b8e643
==========

[commit-bot: I haz the power, 2016-05-02 18:54:16]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0265707c191a31dfde08dd1cd7011c1fe5b8e643