Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1936123002: [gn] Initialize gn for stand-alone v8 (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Initialize gn for stand-alone v8 BUG=chromium:474921 LOG=n Committed: https://crrev.com/c0e119244db02612410e776dd23c12c6263e3cbb Cr-Commit-Position: refs/heads/master@{#35939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A .gn View 1 chunk +40 lines, -0 lines 0 comments Download
A build_overrides/v8.gni View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL. This contains parts of https://codereview.chromium.org/1067293002 with a few modifications to make gn pass. gn ...
4 years, 7 months ago (2016-05-02 14:18:10 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-02 14:33:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936123002/1
4 years, 7 months ago (2016-05-02 14:45:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 15:08:42 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 15:09:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0e119244db02612410e776dd23c12c6263e3cbb
Cr-Commit-Position: refs/heads/master@{#35939}

Powered by Google App Engine
This is Rietveld 408576698