Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1936103003: gpu traits: Move gfx::SwapResult trait to ui/gfx/ipc where it belongs (Closed)

Created:
4 years, 7 months ago by Fady Samuel
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu traits: Move gfx::SwapResult trait to ui/gfx/ipc where it belongs BUG=607904 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e0b09fb8a875ab0b8ac828980bee325d4a17d657 Cr-Commit-Position: refs/heads/master@{#391028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gpu/ipc/common/gpu_param_traits_macros.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits_macros.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936103003/1
4 years, 7 months ago (2016-05-02 15:12:01 UTC) #3
Fady Samuel
+tsepez@ for ipc traits move.
4 years, 7 months ago (2016-05-02 15:13:23 UTC) #5
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-02 15:47:26 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/1075)
4 years, 7 months ago (2016-05-02 16:58:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936103003/1
4 years, 7 months ago (2016-05-02 16:59:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/1076)
4 years, 7 months ago (2016-05-02 17:00:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1936103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1936103003/1
4 years, 7 months ago (2016-05-02 18:17:31 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 19:35:27 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 19:37:53 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0b09fb8a875ab0b8ac828980bee325d4a17d657
Cr-Commit-Position: refs/heads/master@{#391028}

Powered by Google App Engine
This is Rietveld 408576698